From: "Keller, Jacob E" <jacob.e.keller@intel.com>
To: "moorray3@wp.pl" <moorray3@wp.pl>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH 2/2] fm10k: correctly report error when changing number of channels
Date: Mon, 8 Feb 2016 20:07:21 +0000 [thread overview]
Message-ID: <1454962038.25441.17.camel@intel.com> (raw)
In-Reply-To: <20160208192338.7379064f@jkicinski-Precision-T1700>
On Mon, 2016-02-08 at 19:23 +0000, Jakub Kiciński wrote:
> On Mon, 8 Feb 2016 17:13:15 +0000, Keller, Jacob E wrote:
> > Maybe we can store it as a flag in the netdev structure instead?
>
> Either flag in the netdev or keep your reset callback. Neither seems
> spectacularly clean. Maybe someone with a better idea will speak up
> ;)
I chose a priv_flags for netdev, since I think this is better than a
new ethtool op.
I Cc'ed you on the new patch series if you could give it a look? I also
added a few more sanity checks to ethtool_set_channels, in addition to
the check for the rxfh flow table.
Regards,
Jake
prev parent reply other threads:[~2016-02-08 20:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-05 20:30 [PATCH 0/2] ethtool: {SG}RXFH indirection deficiency Jacob Keller
2016-02-05 20:30 ` [PATCH 1/2] ethtool: support notifying drivers when user requests default rxfh table Jacob Keller
2016-02-05 20:30 ` [PATCH 2/2] fm10k: correctly report error when changing number of channels Jacob Keller
2016-02-08 13:26 ` Jakub Kicinski
2016-02-08 17:13 ` Keller, Jacob E
2016-02-08 19:23 ` Jakub Kiciński
2016-02-08 20:07 ` Keller, Jacob E [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454962038.25441.17.camel@intel.com \
--to=jacob.e.keller@intel.com \
--cc=moorray3@wp.pl \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).