From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: paul.durrant@citrix.com, netdev@vger.kernel.org,
j.vosburgh@gmail.com, vfalico@gmail.com,
gospo@cumulusnetworks.com, tom@herbertland.com
Subject: Re: [PATCH net-next] store complete hash type information in socket buffer...
Date: Wed, 17 Feb 2016 22:30:01 +0100 [thread overview]
Message-ID: <1455744601.648.2.camel@edumazet-ThinkPad-T530> (raw)
In-Reply-To: <20160217.154432.788293606088459412.davem@davemloft.net>
On mer., 2016-02-17 at 15:44 -0500, David Miller wrote:
> From: Paul Durrant <paul.durrant@citrix.com>
> Date: Mon, 15 Feb 2016 08:32:08 +0000
>
> > ...rather than a boolean merely indicating a canonical L4 hash.
> >
> > skb_set_hash() takes a hash type (from enum pkt_hash_types) as an
> > argument but information is lost since only a single bit in the skb
> > stores whether that hash type is PKT_HASH_TYPE_L4 or not. By using
> > two bits it's possible to store the complete hash type information.
> >
> > Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
>
> Tom and/or Eric, please have a look at this.
I guess my question is simply 'why do we need this' ?
Consuming a bit in our precious sk_buff is not something we want for
some obscure feature.
next prev parent reply other threads:[~2016-02-17 21:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-15 8:32 [PATCH net-next] store complete hash type information in socket buffer Paul Durrant
2016-02-17 9:01 ` Paul Durrant
2016-02-17 20:44 ` David Miller
2016-02-17 21:30 ` Eric Dumazet [this message]
2016-02-19 2:22 ` Tom Herbert
2016-02-19 8:55 ` Paul Durrant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1455744601.648.2.camel@edumazet-ThinkPad-T530 \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=gospo@cumulusnetworks.com \
--cc=j.vosburgh@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=paul.durrant@citrix.com \
--cc=tom@herbertland.com \
--cc=vfalico@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox