From: Paolo Abeni <pabeni@redhat.com>
To: Jesse Gross <jesse@kernel.org>
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Thomas Graf <tgraf@suug.ch>, Jiri Benc <jbenc@redhat.com>,
Pravin Shelar <pshelar@nicira.com>,
Tom Herbert <tom@herbertland.com>
Subject: Re: [PATCH net v2] lwt: fix rx checksum setting for lwt devices tunneling over ipv6
Date: Thu, 18 Feb 2016 10:42:04 +0100 [thread overview]
Message-ID: <1455788524.29084.8.camel@redhat.com> (raw)
In-Reply-To: <CAEh+42isC=4nmKz-Sjc9VreCbOkqdEcPc2uXyxcgGRJQsdSWSw@mail.gmail.com>
On Wed, 2016-02-17 at 11:19 -0800, Jesse Gross wrote:
> On Wed, Feb 17, 2016 at 10:30 AM, Paolo Abeni <pabeni@redhat.com> wrote:
> > the commit 35e2d1152b22 ("tunnels: Allow IPv6 UDP checksums to be
> > correctly controlled.") changed the default xmit checksum setting
> > for lwt vxlan/geneve ipv6 tunnels, so that now the checksum is not
> > set into external UDP header.
> > This commit changes the rx checksum setting for both lwt vxlan/geneve
> > devices created by openvswitch accordingly, so that lwt over ipv6
> > tunnel pairs are again able to communicate with default values.
> >
> > Signed-off-by: Paolo Abeni <pabeni@redhat.com>
>
> This is compat code that is being changed here. Based on the previous
> discussion, shouldn't these be made the default for all users?
This change was initially aimed at a smaller scope: use self consistent
default for ovs lwt devices/tunnel terminations.
If there is agreement, I can post a separate patch changing the default
rx checksum setting for plain vxlan and geneve[1] devices tunneling over
ipv6.
Paolo
[1] according to the ietf draft the geneve devices have the same
checksum requirement than vxlan ones
next prev parent reply other threads:[~2016-02-18 9:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-17 18:30 [PATCH net v2] lwt: fix rx checksum setting for lwt devices tunneling over ipv6 Paolo Abeni
2016-02-17 19:19 ` Jesse Gross
2016-02-18 9:42 ` Paolo Abeni [this message]
2016-02-18 15:31 ` Jesse Gross
2016-02-18 9:53 ` Jiri Benc
2016-02-19 20:40 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1455788524.29084.8.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=davem@davemloft.net \
--cc=jbenc@redhat.com \
--cc=jesse@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pshelar@nicira.com \
--cc=tgraf@suug.ch \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).