Re: [PATCH RFC v2 net-next 2/2] tcp: Add Redundant Data Bundling (RDB)

Bendik Rønning Opstad
2015-11-23T20:05:57Z

On 23/11/15 18:43, Eric Dumazet wrote:
> On Mon, 2015-11-23 at 17:26 +0100, Bendik Rønning Opstad wrote:
>
>> > +
>> > +tcp_rdb_max_skbs - INTEGER
>> > + Enable restriction on how many previous SKBs in the output queue
>> > + RDB may include data from. A value of 1 will restrict bundling to
>> > + only the data from the last packet that was sent.
>> > + Default: 1
>> > +
> skb is an internal thing. I would rather not expose a sysctl with such
> name.
>
> Can be multi segment or not (if GSO/TSO is enabled)
>
> So even '1' skb can have very different content, from 1 byte to ~64 KB

I see your point about not exposing the internal naming. What about
tcp_rdb_max_packets?