From: Michael Chan <michael.chan@broadcom.com>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, Michael Chan <mchan@broadcom.com>
Subject: [PATCH net 1/3] bnxt_en: Poll link at the end of __bnxt_open_nic().
Date: Fri, 19 Feb 2016 19:43:19 -0500 [thread overview]
Message-ID: <1455929001-12039-2-git-send-email-michael.chan@broadcom.com> (raw)
In-Reply-To: <1455929001-12039-1-git-send-email-michael.chan@broadcom.com>
From: Michael Chan <mchan@broadcom.com>
When shutting down the NIC, we shutdown async event processing before
freeing all the rings. If there is a link change event during reset, the
driver may miss it and the link state may be incorrect after the NIC is
re-opened. Poll the link at the end of __bnxt_open_nic() to get the
correct link status.
Signed-off-by Michael Chan <michael.chan@broadcom.com>
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
index 82f4e6d..9b56058 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
@@ -4662,6 +4662,7 @@ static int __bnxt_open_nic(struct bnxt *bp, bool irq_re_init, bool link_re_init)
/* Enable TX queues */
bnxt_tx_enable(bp);
mod_timer(&bp->timer, jiffies + bp->current_interval);
+ bnxt_update_link(bp, true);
return 0;
--
1.8.3.1
next prev parent reply other threads:[~2016-02-20 0:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-20 0:43 [PATCH net 0/3] bnxt_en: Phy related fixes Michael Chan
2016-02-20 0:43 ` Michael Chan [this message]
2016-02-20 0:43 ` [PATCH net 2/3] bnxt_en: Remove unnecessary call to update PHY settings Michael Chan
2016-02-20 0:43 ` [PATCH net 3/3] bnxt_en: Failure to update PHY is not fatal condition Michael Chan
2016-02-20 4:40 ` [PATCH net 0/3] bnxt_en: Phy related fixes David Miller
2016-02-20 6:08 ` Michael Chan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1455929001-12039-2-git-send-email-michael.chan@broadcom.com \
--to=michael.chan@broadcom.com \
--cc=davem@davemloft.net \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).