From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Kirsher Subject: [net-next 09/20] igb: fix itnull.cocci warnings Date: Tue, 23 Feb 2016 20:26:13 -0800 Message-ID: <1456287984-10459-10-git-send-email-jeffrey.t.kirsher@intel.com> References: <1456287984-10459-1-git-send-email-jeffrey.t.kirsher@intel.com> Cc: Julia Lawall , netdev@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com, jogreene@redhat.com, Gangfeng Huang , Fengguang Wu , Jeff Kirsher To: davem@davemloft.net Return-path: Received: from mga02.intel.com ([134.134.136.20]:57891 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757101AbcBXE0c (ORCPT ); Tue, 23 Feb 2016 23:26:32 -0500 In-Reply-To: <1456287984-10459-1-git-send-email-jeffrey.t.kirsher@intel.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Julia Lawall The index variable of list_for_each_entry_safe should never be NULL. Generated by: scripts/coccinelle/iterators/itnull.cocci CC: Gangfeng Huang Signed-off-by: Julia Lawall Signed-off-by: Fengguang Wu Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/igb/igb_cdev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/intel/igb/igb_cdev.c b/drivers/net/ethernet/intel/igb/igb_cdev.c index 28fafec..5e6579c 100644 --- a/drivers/net/ethernet/intel/igb/igb_cdev.c +++ b/drivers/net/ethernet/intel/igb/igb_cdev.c @@ -411,8 +411,7 @@ static int igb_close_file(struct inode *inode, struct file *file) list_for_each_entry_safe(userpage, tmp, &adapter->user_page_list, page_node) { - if (userpage) - igb_free_page(adapter, userpage); + igb_free_page(adapter, userpage); } } mutex_unlock(&adapter->user_page_mutex); -- 2.5.0