From: Ivan Vecera <ivecera@redhat.com>
To: netdev@vger.kernel.org
Cc: Sathya Perla <sathya.perla@broadcom.com>,
Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>
Subject: [PATCH net] be2net: don't {en,dis}able filters on BE3 when transparent tagging is enabled
Date: Fri, 26 Feb 2016 09:46:41 +0100 [thread overview]
Message-ID: <1456476401-23398-1-git-send-email-ivecera@redhat.com> (raw)
The FILTMGMT privilege is necessary on BE3 chip to manipulare filters
like MC, UC list management, VLAN filter, promisc mode... This privilege
is dropped for VFs when transparrent tagging is enabled on them. This
prevents to make interface up for such VF because be_enable_if_filters()
called from be_open() fails thus be_open() also fails.
Cc: Sathya Perla <sathya.perla@broadcom.com>
Cc: Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>
Signed-off-by: Ivan Vecera <ivecera@redhat.com>
---
drivers/net/ethernet/emulex/benet/be_main.c | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c
index f99de36..2e176f6 100644
--- a/drivers/net/ethernet/emulex/benet/be_main.c
+++ b/drivers/net/ethernet/emulex/benet/be_main.c
@@ -3430,7 +3430,8 @@ static int be_close(struct net_device *netdev)
if (!(adapter->flags & BE_FLAGS_SETUP_DONE))
return 0;
- be_disable_if_filters(adapter);
+ if (!(BEx_chip(adapter) && be_pvid_tagging_enabled(adapter)))
+ be_disable_if_filters(adapter);
if (adapter->flags & BE_FLAGS_NAPI_ENABLED) {
for_all_evt_queues(adapter, eqo, i) {
@@ -3571,9 +3572,11 @@ static int be_open(struct net_device *netdev)
if (status)
goto err;
- status = be_enable_if_filters(adapter);
- if (status)
- goto err;
+ if (!(BEx_chip(adapter) && be_pvid_tagging_enabled(adapter))) {
+ status = be_enable_if_filters(adapter);
+ if (status)
+ goto err;
+ }
status = be_irq_register(adapter);
if (status)
--
2.4.10
next reply other threads:[~2016-02-26 8:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-26 8:46 Ivan Vecera [this message]
2016-02-26 11:36 ` [PATCH net] be2net: don't {en,dis}able filters on BE3 when transparent tagging is enabled Sathya Perla
2016-02-26 12:24 ` Ivan Vecera
2016-02-26 12:44 ` Sathya Perla
2016-02-26 13:13 ` Ivan Vecera
2016-02-29 4:11 ` Sathya Perla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456476401-23398-1-git-send-email-ivecera@redhat.com \
--to=ivecera@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=sathya.perla@broadcom.com \
--cc=sriharsha.basavapatna@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).