public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Peter Hurley <peter@hurleysoftware.com>
Cc: Mike Galbraith <umgwanakikbuti@gmail.com>,
	Francois Romieu <romieu@fr.zoreil.com>,
	Eric Dumazet <edumazet@google.com>,
	David Miller <davem@davemloft.net>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	Greg KH <gregkh@linuxfoundation.org>,
	dmaengine@vger.kernel.org,
	John Ogness <john.ogness@linutronix.de>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: Softirq priority inversion from "softirq: reduce latencies"
Date: Mon, 29 Feb 2016 08:21:54 -0800	[thread overview]
Message-ID: <1456762914.648.76.camel@edumazet-ThinkPad-T530> (raw)
In-Reply-To: <56D469B2.2070707@hurleysoftware.com>

On lun., 2016-02-29 at 07:54 -0800, Peter Hurley wrote:

>  The current kernel is HZ=250 but this would occur on HZ=1000 as well.

Right. But the problem with HZ=100 and HZ=250 is that the detection can
happens because jiffy granularity is too coarse, since 

msecs_to_jiffies(2) -> 1

Following patch might reduce the probability, but wont really fix your
problem.

Fact that ksoftirqd prio is not what you want is completely orthogonal.

diff --git a/kernel/softirq.c b/kernel/softirq.c
index 479e443..f7cc594 100644
--- a/kernel/softirq.c
+++ b/kernel/softirq.c
@@ -180,7 +180,7 @@ EXPORT_SYMBOL(__local_bh_enable_ip);
 
 /*
  * We restart softirq processing for at most MAX_SOFTIRQ_RESTART times,
- * but break the loop if need_resched() is set or after 2 ms.
+ * but break the loop if need_resched() is set or after 2 ms/ticks.
  * The MAX_SOFTIRQ_TIME provides a nice upper bound in most cases, but in
  * certain cases, such as stop_machine(), jiffies may cease to
  * increment and so we need the MAX_SOFTIRQ_RESTART limit as
@@ -191,7 +191,7 @@ EXPORT_SYMBOL(__local_bh_enable_ip);
  * we want to handle softirqs as soon as possible, but they
  * should not be able to lock up the box.
  */
-#define MAX_SOFTIRQ_TIME  msecs_to_jiffies(2)
+#define MAX_SOFTIRQ_TIME  (1 + msecs_to_jiffies(2))
 #define MAX_SOFTIRQ_RESTART 10
 
 #ifdef CONFIG_TRACE_IRQFLAGS

  reply	other threads:[~2016-02-29 16:22 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-27 18:19 Softirq priority inversion from "softirq: reduce latencies" Peter Hurley
2016-02-27 20:13 ` Eric Dumazet
2016-02-27 20:29   ` Peter Hurley
2016-02-27 23:04     ` David Miller
2016-02-27 23:33       ` Peter Hurley
2016-02-28  1:59         ` Eric Dumazet
2016-02-28  2:10           ` Peter Hurley
2016-02-28  2:17             ` Eric Dumazet
2016-02-28  4:46             ` David Miller
2016-02-28  5:55 ` Mike Galbraith
2016-02-28 17:01   ` Francois Romieu
2016-02-29  4:58     ` Mike Galbraith
2016-02-29 15:03       ` Peter Hurley
2016-02-29 15:19         ` Eric Dumazet
2016-02-29 15:54           ` Peter Hurley
2016-02-29 16:21             ` Eric Dumazet [this message]
2016-02-29 18:05               ` Peter Hurley
2016-02-29 18:24                 ` Eric Dumazet
2016-02-29 18:53                   ` Peter Hurley
2016-02-29 19:14                     ` Thomas Gleixner
2016-02-29 20:24                       ` David Miller
2016-02-29 23:04                       ` Peter Hurley
2016-02-29 15:27         ` Eric Dumazet
2016-02-29 19:13           ` Peter Hurley
2016-02-29 19:43             ` Eric Dumazet
2016-02-29 15:40         ` Mike Galbraith
2016-02-29 15:58           ` Peter Hurley
2016-02-29 16:24             ` Eric Dumazet
2016-02-29 17:16         ` David Miller
2016-03-07 15:31       ` Sebastian Andrzej Siewior
2016-03-07 17:06         ` Mike Galbraith
2016-03-07 15:48 ` Sebastian Andrzej Siewior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1456762914.648.76.camel@edumazet-ThinkPad-T530 \
    --to=eric.dumazet@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=bigeasy@linutronix.de \
    --cc=davem@davemloft.net \
    --cc=dmaengine@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=john.ogness@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=peter@hurleysoftware.com \
    --cc=romieu@fr.zoreil.com \
    --cc=tglx@linutronix.de \
    --cc=umgwanakikbuti@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox