From: Eric Dumazet <eric.dumazet@gmail.com>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: Daniel Borkmann <daniel@iogearbox.net>,
Linux Kernel Network Developers <netdev@vger.kernel.org>,
Eric Dumazet <edumazet@google.com>
Subject: Re: [Patch net-next] net: remove skb_sender_cpu_clear()
Date: Mon, 29 Feb 2016 11:30:33 -0800 [thread overview]
Message-ID: <1456774233.648.91.camel@edumazet-ThinkPad-T530> (raw)
In-Reply-To: <CAM_iQpUtGbSnvV3Zi74Q5DsZBAAFGZyvjkkeBRciHxwTm4GCEg@mail.gmail.com>
On lun., 2016-02-29 at 10:55 -0800, Cong Wang wrote:
> On Mon, Feb 29, 2016 at 10:50 AM, Daniel Borkmann <daniel@iogearbox.net> wrote:
> > On 02/28/2016 05:19 AM, Cong Wang wrote:
> >>
> >> After commit 52bd2d62ce67 ("net: better skb->sender_cpu and skb->napi_id
> >> cohabitation")
> >> skb_sender_cpu_clear() becomes empty and can be removed.
> >>
> >> Cc: Eric Dumazet <edumazet@google.com>
> >> Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
> >
> >
> > Wasn't the intention to keep this helper as a marker when packet
> > crosses domains from RX to TX, see discussion here:
> >
> > https://patchwork.ozlabs.org/patch/527167/
> >
> > Maybe better to rename it and add a comment into the helper to
> > make the intention more clear?
>
> Since when we need an empty function to mark some call path?
> Isn't this supposed to be done by comments or documents?
>
> BTW, I myself even don't think we need any comment, people
> who touches it should understand it.
I have no objections for this patch.
If we keep the helper, a better name would be needed anyway.
next prev parent reply other threads:[~2016-02-29 19:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-28 4:19 [Patch net-next] net: remove skb_sender_cpu_clear() Cong Wang
2016-02-29 18:50 ` Daniel Borkmann
2016-02-29 18:55 ` Cong Wang
2016-02-29 19:30 ` Eric Dumazet [this message]
2016-03-01 22:36 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456774233.648.91.camel@edumazet-ThinkPad-T530 \
--to=eric.dumazet@gmail.com \
--cc=daniel@iogearbox.net \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox