netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, ben@decadent.org.uk,
	Nicolas Dichtel <nicolas.dichtel@6wind.com>,
	Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Subject: [PATCH net-next v2 2/2] ethtool.h: define INT_MAX for userland
Date: Tue,  1 Mar 2016 17:41:04 +0100	[thread overview]
Message-ID: <1456850464-23003-2-git-send-email-nicolas.dichtel@6wind.com> (raw)
In-Reply-To: <1456850464-23003-1-git-send-email-nicolas.dichtel@6wind.com>

INT_MAX needs limits.h in userland.
When ethtool.h is included by a userland app, we got the following error:

.../usr/include/linux/ethtool.h: In function 'ethtool_validate_speed':
.../usr/include/linux/ethtool.h:1471:18: error: 'INT_MAX' undeclared (first use in this function)
  return speed <= INT_MAX || speed == SPEED_UNKNOWN
                  ^

Fixes: e02564ee334a ("ethtool: make validate_speed accept all speeds between 0 and INT_MAX")
CC: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
---

v2: split the patch
    define DIV_ROUND_UP in uapi

 include/uapi/linux/ethtool.h | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/include/uapi/linux/ethtool.h b/include/uapi/linux/ethtool.h
index 9c22249ebf35..2835b07416b7 100644
--- a/include/uapi/linux/ethtool.h
+++ b/include/uapi/linux/ethtool.h
@@ -17,6 +17,10 @@
 #include <linux/types.h>
 #include <linux/if_ether.h>
 
+#ifndef __KERNEL__
+#include <limits.h> /* for INT_MAX */
+#endif
+
 /* All structures exposed to userland should be defined such that they
  * have the same layout for 32-bit and 64-bit userland.
  */
-- 
2.4.2

  reply	other threads:[~2016-03-01 16:41 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-01 15:20 [PATCH net-next] ethtool.h: define DIV_ROUND_UP for userland Nicolas Dichtel
2016-03-01 15:29 ` Ben Hutchings
2016-03-01 16:41   ` [PATCH net-next v2 1/2] uapi: " Nicolas Dichtel
2016-03-01 16:41     ` Nicolas Dichtel [this message]
2016-03-03 21:43       ` [PATCH net-next v2 2/2] ethtool.h: define INT_MAX " David Miller
2016-03-03 21:43     ` [PATCH net-next v2 1/2] uapi: define DIV_ROUND_UP " David Miller
2016-03-03 22:08       ` David Miller
2016-03-04 10:52         ` [PATCH net-next v3 0/4] uapi: consolidate DIV_ROUND_UP definition Nicolas Dichtel
2016-03-04 10:52           ` [PATCH net-next v3 1/4] uapi: define DIV_ROUND_UP for userland Nicolas Dichtel
2016-03-04 10:52           ` [PATCH net-next v3 2/4] cxgb4i: don't redefine DIV_ROUND_UP Nicolas Dichtel
2016-03-04 10:52           ` [PATCH net-next v3 3/4] drm/vmwgfx: remove userland definition of DIV_ROUND_UP Nicolas Dichtel
2016-03-04 21:36             ` Emil Velikov
2016-03-04 10:52           ` [PATCH net-next v3 4/4] ethtool.h: define INT_MAX for userland Nicolas Dichtel
2016-03-04 13:10             ` Nikolay Aleksandrov
2016-03-04 21:10           ` [PATCH net-next v3 0/4] uapi: consolidate DIV_ROUND_UP definition David Miller
2016-03-01 16:42 ` [PATCH net-next] ethtool.h: define DIV_ROUND_UP for userland David Miller
2016-03-01 17:14   ` Ben Hutchings
2016-03-01 19:48     ` David Miller
2016-03-01 20:06       ` Ben Hutchings

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1456850464-23003-2-git-send-email-nicolas.dichtel@6wind.com \
    --to=nicolas.dichtel@6wind.com \
    --cc=ben@decadent.org.uk \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=nikolay@cumulusnetworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).