From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: John Holland <jotihojr@gmail.com>,
"Brown, Aaron F" <aaron.f.brown@intel.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"intel-wired-lan@lists.osuosl.org"
<intel-wired-lan@lists.osuosl.org>
Subject: Re: [Intel-wired-lan] [next] igb: allow setting MAC address on i211 using a device tree blob V5
Date: Tue, 01 Mar 2016 15:55:09 -0800 [thread overview]
Message-ID: <1456876509.3039.10.camel@intel.com> (raw)
In-Reply-To: <DC20A3D2-95E2-420B-911D-C6AC02338227@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 808 bytes --]
On Tue, 2016-03-01 at 07:56 +0100, John Holland wrote:
> On Mar 1, 2016, at 03:52, Brown, Aaron F <aaron.f.brown@intel.com>
> wrote:
>
> > This throws a few checkpatch warnings, but I won't withhold my
> tested by for these:
> >
> > total: 0 errors, 2 warnings, 0 checks, 21 lines checked
> >
> > Your patch has style problems, please review.
> >
> > NOTE: If any of the errors are false positives, please report
> > them to the maintainer, see CHECKPATCH in MAINTAINERS.
> > u1463:[0]/usr/src/kernels/next-queue>
>
> Thanks for testing...
>
> Do you require me to reformat the patch text? And won't that break
> the link?
No, that checkpatch.pl warning on the link you provided is fine,
although I will clean up your signed-off-by when I go to push it
upstream. :-)
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-03-01 23:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-18 11:10 [Intel-wired-lan] [next] igb: allow setting MAC address on i211 using a device tree blob V5 John Holland
2016-02-18 13:43 ` John Holland
2016-03-01 2:52 ` Brown, Aaron F
2016-03-01 6:56 ` John Holland
2016-03-01 23:23 ` Brown, Aaron F
2016-03-01 23:55 ` Jeff Kirsher [this message]
2016-03-02 3:48 ` John Holland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456876509.3039.10.camel@intel.com \
--to=jeffrey.t.kirsher@intel.com \
--cc=aaron.f.brown@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jotihojr@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).