* [PATCH 0/6] treewide: test clock rate to avoid division by 0
@ 2016-03-02 22:33 Wolfram Sang
2016-03-02 22:33 ` [PATCH 2/6] net: ethernet: renesas: ravb_main: " Wolfram Sang
0 siblings, 1 reply; 5+ messages in thread
From: Wolfram Sang @ 2016-03-02 22:33 UTC (permalink / raw)
To: linux-kernel
Cc: linux-renesas-soc, linux-arm-kernel, linux-ide, linux-pwm,
linux-watchdog, netdev
Here is the outcome of researching if the result of clk_get_rate() was directly
used as a divisor without checking if it is 0. Inspired by a Coverity report.
Wolfram Sang (6):
ide: palm_bk3710: test clock rate to avoid division by 0
net: ethernet: renesas: ravb_main: test clock rate to avoid division
by 0
pwm: pwm-img: test clock rate to avoid division by 0
pwm: pwm-lpc18xx-sct: test clock rate to avoid division by 0
watchdog: atlas7_wdt: test clock rate to avoid division by 0
watchdog: tangox_wdt: test clock rate to avoid division by 0
drivers/ide/palm_bk3710.c | 2 ++
drivers/net/ethernet/renesas/ravb_main.c | 3 +++
drivers/pwm/pwm-img.c | 5 +++++
drivers/pwm/pwm-lpc18xx-sct.c | 2 ++
drivers/watchdog/atlas7_wdt.c | 5 +++++
drivers/watchdog/tangox_wdt.c | 2 ++
6 files changed, 19 insertions(+)
--
2.7.0
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH 2/6] net: ethernet: renesas: ravb_main: test clock rate to avoid division by 0
2016-03-02 22:33 [PATCH 0/6] treewide: test clock rate to avoid division by 0 Wolfram Sang
@ 2016-03-02 22:33 ` Wolfram Sang
2016-03-03 11:14 ` Sergei Shtylyov
2016-04-03 21:36 ` Wolfram Sang
0 siblings, 2 replies; 5+ messages in thread
From: Wolfram Sang @ 2016-03-02 22:33 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-renesas-soc, Sergei Shtylyov, netdev
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
The clk API may return 0 on clk_get_rate, so we should check the result before
using it as a divisor.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
Should go individually via subsystem tree.
drivers/net/ethernet/renesas/ravb_main.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c
index 88656ceb6e2946..ce1954a6a12726 100644
--- a/drivers/net/ethernet/renesas/ravb_main.c
+++ b/drivers/net/ethernet/renesas/ravb_main.c
@@ -1691,6 +1691,9 @@ static int ravb_set_gti(struct net_device *ndev)
rate = clk_get_rate(clk);
clk_put(clk);
+ if (!rate)
+ return -EINVAL;
+
inc = 1000000000ULL << 20;
do_div(inc, rate);
--
2.7.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 2/6] net: ethernet: renesas: ravb_main: test clock rate to avoid division by 0
2016-03-02 22:33 ` [PATCH 2/6] net: ethernet: renesas: ravb_main: " Wolfram Sang
@ 2016-03-03 11:14 ` Sergei Shtylyov
2016-04-03 21:36 ` Wolfram Sang
1 sibling, 0 replies; 5+ messages in thread
From: Sergei Shtylyov @ 2016-03-03 11:14 UTC (permalink / raw)
To: Wolfram Sang, linux-kernel; +Cc: linux-renesas-soc, netdev
Hello.
On 3/3/2016 1:33 AM, Wolfram Sang wrote:
> From: Wolfram Sang <wsa+renesas@sang-engineering.com>
>
> The clk API may return 0 on clk_get_rate, so we should check the result before
> using it as a divisor.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Acked-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
MBR, Sergei
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/6] net: ethernet: renesas: ravb_main: test clock rate to avoid division by 0
2016-03-02 22:33 ` [PATCH 2/6] net: ethernet: renesas: ravb_main: " Wolfram Sang
2016-03-03 11:14 ` Sergei Shtylyov
@ 2016-04-03 21:36 ` Wolfram Sang
2016-04-03 22:28 ` Sergei Shtylyov
1 sibling, 1 reply; 5+ messages in thread
From: Wolfram Sang @ 2016-04-03 21:36 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-renesas-soc, Sergei Shtylyov, netdev
[-- Attachment #1: Type: text/plain, Size: 971 bytes --]
On Wed, Mar 02, 2016 at 11:33:33PM +0100, Wolfram Sang wrote:
> From: Wolfram Sang <wsa+renesas@sang-engineering.com>
>
> The clk API may return 0 on clk_get_rate, so we should check the result before
> using it as a divisor.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Ping.
> ---
>
> Should go individually via subsystem tree.
>
> drivers/net/ethernet/renesas/ravb_main.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c
> index 88656ceb6e2946..ce1954a6a12726 100644
> --- a/drivers/net/ethernet/renesas/ravb_main.c
> +++ b/drivers/net/ethernet/renesas/ravb_main.c
> @@ -1691,6 +1691,9 @@ static int ravb_set_gti(struct net_device *ndev)
> rate = clk_get_rate(clk);
> clk_put(clk);
>
> + if (!rate)
> + return -EINVAL;
> +
> inc = 1000000000ULL << 20;
> do_div(inc, rate);
>
> --
> 2.7.0
>
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-04-03 22:28 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-02 22:33 [PATCH 0/6] treewide: test clock rate to avoid division by 0 Wolfram Sang
2016-03-02 22:33 ` [PATCH 2/6] net: ethernet: renesas: ravb_main: " Wolfram Sang
2016-03-03 11:14 ` Sergei Shtylyov
2016-04-03 21:36 ` Wolfram Sang
2016-04-03 22:28 ` Sergei Shtylyov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).