From: Amir Vadai <amir@vadai.me>
To: "David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org,
John Fastabend <john.r.fastabend@intel.com>,
Jiri Pirko <jiri@mellanox.com>,
Or Gerlitz <ogerlitz@mellanox.com>,
Saeed Mahameed <saeedm@mellanox.com>,
Hadar Har-Zion <hadarh@mellanox.com>,
Rony Efraim <ronye@mellanox.com>, Amir Vadai <amir@vadai.me>
Subject: [PATCH net-next V1 06/10] net/mlx5e: Relax ndo_setup_tc handle restriction
Date: Thu, 3 Mar 2016 11:23:22 +0200 [thread overview]
Message-ID: <1456997006-18538-7-git-send-email-amir@vadai.me> (raw)
In-Reply-To: <1456997006-18538-1-git-send-email-amir@vadai.me>
Restricting handle to TC_H_ROOT breaks the old instantiation of mqprio
to setup a hardware qdisc. This patch relaxes the test, to only check the
type.
Fixes: 08fb1da ("net/mlx5e: Support DCBNL IEEE ETS")
Signed-off-by: Amir Vadai <amir@vadai.me>
---
drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
index 5063c0e..5e3692f 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
@@ -1883,7 +1883,7 @@ static int mlx5e_setup_tc(struct net_device *netdev, u8 tc)
static int mlx5e_ndo_setup_tc(struct net_device *dev, u32 handle,
__be16 proto, struct tc_to_netdev *tc)
{
- if (handle != TC_H_ROOT || tc->type != TC_SETUP_MQPRIO)
+ if (tc->type != TC_SETUP_MQPRIO)
return -EINVAL;
return mlx5e_setup_tc(dev, tc->tc);
--
2.7.0
next prev parent reply other threads:[~2016-03-03 9:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-03 9:23 [PATCH net-next V1 00/10] cls_flower hardware offload support Amir Vadai
2016-03-03 9:23 ` [PATCH net-next V1 01/10] net/flower: Introduce " Amir Vadai
2016-03-03 9:40 ` Jiri Pirko
2016-03-03 9:23 ` [PATCH net-next V1 02/10] net/flow_dissector: Make dissector_uses_key() and skb_flow_dissector_target() public Amir Vadai
2016-03-03 9:40 ` Jiri Pirko
2016-03-03 9:23 ` [PATCH net-next V1 03/10] net/sched: Macro instead of CONFIG_NET_CLS_ACT ifdef Amir Vadai
2016-03-03 9:38 ` Jiri Pirko
2016-03-03 9:23 ` [PATCH net-next V1 04/10] net/act_skbedit: Utility functions for mark action Amir Vadai
2016-03-03 9:40 ` Jiri Pirko
2016-03-03 9:23 ` [PATCH net-next V1 05/10] net/mlx5_core: Set flow steering dest only for forward rules Amir Vadai
2016-03-03 9:23 ` Amir Vadai [this message]
2016-03-03 9:23 ` [PATCH net-next V1 07/10] net/mlx5e: Add a new priority for kernel flow tables Amir Vadai
2016-03-03 9:23 ` [PATCH net-next V1 08/10] net/mlx5e: Introduce tc offload support Amir Vadai
2016-03-03 9:23 ` [PATCH net-next V1 09/10] net/mlx5e: Support offload cls_flower with drop action Amir Vadai
2016-03-03 9:23 ` [PATCH net-next V1 10/10] net/mlx5e: Support offload cls_flower with skbedit mark action Amir Vadai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456997006-18538-7-git-send-email-amir@vadai.me \
--to=amir@vadai.me \
--cc=davem@davemloft.net \
--cc=hadarh@mellanox.com \
--cc=jiri@mellanox.com \
--cc=john.r.fastabend@intel.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=ronye@mellanox.com \
--cc=saeedm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).