* [PATCH] net: eth: altera: do not free array priv->mdio->irq
@ 2016-03-03 13:47 Colin King
2016-03-03 15:16 ` Andrew Lunn
2016-03-07 3:59 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Colin King @ 2016-03-03 13:47 UTC (permalink / raw)
To: Vince Bridgers, netdev, nios2-dev; +Cc: linux-kernel
From: Colin Ian King <colin.king@canonical.com>
priv->mdio->irq used to be allocated and required freeing, but it
is now a fixed sized array and should no longer be free'd.
Issue detected using static analysis with CoverityScan
Fixes: e7f4dc3536a400 ("mdio: Move allocation of interrupts into core")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/ethernet/altera/altera_tse_main.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/altera/altera_tse_main.c b/drivers/net/ethernet/altera/altera_tse_main.c
index 1747285..f749e4d 100644
--- a/drivers/net/ethernet/altera/altera_tse_main.c
+++ b/drivers/net/ethernet/altera/altera_tse_main.c
@@ -193,7 +193,6 @@ static void altera_tse_mdio_destroy(struct net_device *dev)
priv->mdio->id);
mdiobus_unregister(priv->mdio);
- kfree(priv->mdio->irq);
mdiobus_free(priv->mdio);
priv->mdio = NULL;
}
--
2.7.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] net: eth: altera: do not free array priv->mdio->irq
2016-03-03 13:47 [PATCH] net: eth: altera: do not free array priv->mdio->irq Colin King
@ 2016-03-03 15:16 ` Andrew Lunn
2016-03-07 3:59 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2016-03-03 15:16 UTC (permalink / raw)
To: Colin King; +Cc: Vince Bridgers, netdev, nios2-dev, linux-kernel
On Thu, Mar 03, 2016 at 01:47:18PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> priv->mdio->irq used to be allocated and required freeing, but it
> is now a fixed sized array and should no longer be free'd.
>
> Issue detected using static analysis with CoverityScan
>
> Fixes: e7f4dc3536a400 ("mdio: Move allocation of interrupts into core")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Thanks
Andrew
> ---
> drivers/net/ethernet/altera/altera_tse_main.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/altera/altera_tse_main.c b/drivers/net/ethernet/altera/altera_tse_main.c
> index 1747285..f749e4d 100644
> --- a/drivers/net/ethernet/altera/altera_tse_main.c
> +++ b/drivers/net/ethernet/altera/altera_tse_main.c
> @@ -193,7 +193,6 @@ static void altera_tse_mdio_destroy(struct net_device *dev)
> priv->mdio->id);
>
> mdiobus_unregister(priv->mdio);
> - kfree(priv->mdio->irq);
> mdiobus_free(priv->mdio);
> priv->mdio = NULL;
> }
> --
> 2.7.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] net: eth: altera: do not free array priv->mdio->irq
2016-03-03 13:47 [PATCH] net: eth: altera: do not free array priv->mdio->irq Colin King
2016-03-03 15:16 ` Andrew Lunn
@ 2016-03-07 3:59 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2016-03-07 3:59 UTC (permalink / raw)
To: colin.king; +Cc: vbridger, netdev, nios2-dev, linux-kernel
From: Colin King <colin.king@canonical.com>
Date: Thu, 3 Mar 2016 13:47:18 +0000
> From: Colin Ian King <colin.king@canonical.com>
>
> priv->mdio->irq used to be allocated and required freeing, but it
> is now a fixed sized array and should no longer be free'd.
>
> Issue detected using static analysis with CoverityScan
>
> Fixes: e7f4dc3536a400 ("mdio: Move allocation of interrupts into core")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-03-07 3:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-03 13:47 [PATCH] net: eth: altera: do not free array priv->mdio->irq Colin King
2016-03-03 15:16 ` Andrew Lunn
2016-03-07 3:59 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).