From: Joe Perches <joe@perches.com>
To: John Crispin <blogic@openwrt.org>,
"David S. Miller" <davem@davemloft.net>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
"Steven Liu (劉人豪)" <steven.liu@mediatek.com>,
"Carlos Huang (黃士彰)" <Carlos.Huang@mediatek.com>,
"Felix Fietkau" <nbd@openwrt.org>,
"Michael Lee" <igvtee@gmail.com>
Subject: Re: [PATCH V3 2/4] net-next: mediatek: add support for MT7623 ethernet
Date: Thu, 03 Mar 2016 13:06:55 -0800 [thread overview]
Message-ID: <1457039215.4044.122.camel@perches.com> (raw)
In-Reply-To: <1457035361-57669-3-git-send-email-blogic@openwrt.org>
On Thu, 2016-03-03 at 21:02 +0100, John Crispin wrote:
> Add ethernet support for MediaTek SoCs from the MT7623 family.
[]
> diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.h b/drivers/net/ethernet/mediatek/mtk_eth_soc.h
[]
> +/* ugly macro hack to make sure hw_stats and ethtool strings are consistent */
I agree and think the _FE macros defines and uses should be removed.
next prev parent reply other threads:[~2016-03-03 21:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-03 20:02 [PATCH V3 0/4] net-next: mediatek: add ethernet driver John Crispin
2016-03-03 20:02 ` [PATCH V3 1/4] net-next: mediatek: document MediaTek SoC ethernet binding John Crispin
2016-03-05 4:30 ` Rob Herring
2016-03-03 20:02 ` [PATCH V3 2/4] net-next: mediatek: add support for MT7623 ethernet John Crispin
2016-03-03 21:06 ` Joe Perches [this message]
2016-03-04 10:50 ` David Laight
2016-03-03 20:02 ` [PATCH V3 3/4] net-next: mediatek: add Kconfig and Makefile John Crispin
2016-03-03 20:02 ` [PATCH V3 4/4] net-next: mediatek: add an entry to MAINTAINERS John Crispin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1457039215.4044.122.camel@perches.com \
--to=joe@perches.com \
--cc=Carlos.Huang@mediatek.com \
--cc=blogic@openwrt.org \
--cc=davem@davemloft.net \
--cc=igvtee@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=nbd@openwrt.org \
--cc=netdev@vger.kernel.org \
--cc=steven.liu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).