[PATCH 0/1] be2net: Don't leak iomapped memory on removal.

[PATCH 0/1] be2net: Don't leak iomapped memory on removal.

[Douglas Miller]

The adapter->pcicfg resource is either mapped via pci_iomap() or
derived from adapter->db. During be_remove() this resource was ignored
and so could remain mapped after remove.
    
Add a flag to track whether adapter->pcicfg was mapped or not, then
use that flag in be_unmap_pci_bars() to unmap if required.
    
Signed-off-by: Douglas Miller <dougmill@linux.vnet.ibm.com>

[PATCH 1/1] be2net: Don't leak iomapped memory on removal.

[Douglas Miller]

The adapter->pcicfg resource is either mapped via pci_iomap() or
derived from adapter->db. During be_remove() this resource was ignored
and so could remain mapped after remove.

Add a flag to track whether adapter->pcicfg was mapped or not, then
use that flag in be_unmap_pci_bars() to unmap if required.

Signed-off-by: Douglas Miller <dougmill@linux.vnet.ibm.com>
---
 drivers/net/ethernet/emulex/benet/be.h      |    1 +
 drivers/net/ethernet/emulex/benet/be_main.c |    4 ++++
 2 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/drivers/net/ethernet/emulex/benet/be.h b/drivers/net/ethernet/emulex/benet/be.h
index cf83783..f975129 100644
--- a/drivers/net/ethernet/emulex/benet/be.h
+++ b/drivers/net/ethernet/emulex/benet/be.h
@@ -531,6 +531,7 @@ struct be_adapter {
 
 	struct delayed_work be_err_detection_work;
 	u8 err_flags;
+	bool pcicfg_mapped;	/* pcicfg obtained via pci_iomap() */
 	u32 flags;
 	u32 cmd_privileges;
 	/* Ethtool knobs and info */
diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c
index f99de36..a79b8a5 100644
--- a/drivers/net/ethernet/emulex/benet/be_main.c
+++ b/drivers/net/ethernet/emulex/benet/be_main.c
@@ -4968,6 +4968,8 @@ static void be_unmap_pci_bars(struct be_adapter *adapter)
 		pci_iounmap(adapter->pdev, adapter->csr);
 	if (adapter->db)
 		pci_iounmap(adapter->pdev, adapter->db);
+	if (adapter->pcicfg && adapter->pcicfg_mapped)
+		pci_iounmap(adapter->pdev, adapter->pcicfg);
 }
 
 static int db_bar(struct be_adapter *adapter)
@@ -5019,8 +5021,10 @@ static int be_map_pci_bars(struct be_adapter *adapter)
 			if (!addr)
 				goto pci_map_err;
 			adapter->pcicfg = addr;
+			adapter->pcicfg_mapped = 1;
 		} else {
 			adapter->pcicfg = adapter->db + SRIOV_VF_PCICFG_OFFSET;
+			adapter->pcicfg_mapped = 0;
 		}
 	}
 
-- 
1.7.1

Re: [PATCH 1/1] be2net: Don't leak iomapped memory on removal.

[Sathya Perla]

On Fri, Mar 4, 2016 at 4:05 AM, Douglas Miller
<dougmill@linux.vnet.ibm.com> wrote:
> The adapter->pcicfg resource is either mapped via pci_iomap() or
> derived from adapter->db. During be_remove() this resource was ignored
> and so could remain mapped after remove.
>
> Add a flag to track whether adapter->pcicfg was mapped or not, then
> use that flag in be_unmap_pci_bars() to unmap if required.
>
> Signed-off-by: Douglas Miller <dougmill@linux.vnet.ibm.com>

Acked-by: Sathya Perla <sathya.perla@broadcom.com>

Could you pls add the "fixes" tag line to this patch:
Fixes: 25848c901 ("use PCI MMIO read instead of config read for errors")

thanks for the fix,
-Sathya

Re: [PATCH 1/1] be2net: Don't leak iomapped memory on removal.

[Sergei Shtylyov]

Hello.

On 3/4/2016 1:35 AM, Douglas Miller wrote:

> The adapter->pcicfg resource is either mapped via pci_iomap() or
> derived from adapter->db. During be_remove() this resource was ignored
> and so could remain mapped after remove.
>
> Add a flag to track whether adapter->pcicfg was mapped or not, then
> use that flag in be_unmap_pci_bars() to unmap if required.
>
> Signed-off-by: Douglas Miller <dougmill@linux.vnet.ibm.com>
> ---
>   drivers/net/ethernet/emulex/benet/be.h      |    1 +
>   drivers/net/ethernet/emulex/benet/be_main.c |    4 ++++
>   2 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/ethernet/emulex/benet/be.h b/drivers/net/ethernet/emulex/benet/be.h
> index cf83783..f975129 100644
> --- a/drivers/net/ethernet/emulex/benet/be.h
> +++ b/drivers/net/ethernet/emulex/benet/be.h
> @@ -531,6 +531,7 @@ struct be_adapter {
>
>   	struct delayed_work be_err_detection_work;
>   	u8 err_flags;
> +	bool pcicfg_mapped;	/* pcicfg obtained via pci_iomap() */
>   	u32 flags;
>   	u32 cmd_privileges;
>   	/* Ethtool knobs and info */
> diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c
> index f99de36..a79b8a5 100644
> --- a/drivers/net/ethernet/emulex/benet/be_main.c
> +++ b/drivers/net/ethernet/emulex/benet/be_main.c
[...]
> @@ -5019,8 +5021,10 @@ static int be_map_pci_bars(struct be_adapter *adapter)
>   			if (!addr)
>   				goto pci_map_err;
>   			adapter->pcicfg = addr;
> +			adapter->pcicfg_mapped = 1;

    s/1/true/.

>   		} else {
>   			adapter->pcicfg = adapter->db + SRIOV_VF_PCICFG_OFFSET;
> +			adapter->pcicfg_mapped = 0;

    s/0/false/.

[...]

MBR, Sergei