Re: [net-next PATCH v2] net_sched: dsmark: use qdisc_dequeue_peeked()

David Miller
2016-03-07T03:49:23Z

From: Kyeong Yoo <Kyeong.Yoo@alliedtelesis.co.nz>
Date: Thu, 3 Mar 2016 10:25:19 +0000

> This fix is for dsmark similar to commit 3557619f0f6f7496ed453d4825e249
> ("net_sched: prio: use qdisc_dequeue_peeked")
> and makes use of qdisc_dequeue_peeked() instead of direct dequeue() call.
>
> First time, wrr peeks dsmark, which will then peek into sfq.
> sfq dequeues an skb and it's stored in sch->gso_skb.
> Next time, wrr tries to dequeue from dsmark, which will call sfq dequeue
> directly. This results skipping the previously peeked skb.
>
> So changed dsmark dequeue to call qdisc_dequeue_peeked() instead to use
> peeked skb if exists.
>
> Signed-off-by: Kyeong Yoo <kyeong.yoo@alliedtelesis.co.nz>

Your patch is corrupted by your email client, it has MS-DOS style
newlines, etc.