From: David Howells <dhowells@redhat.com>
To: Hillf Danton <hdanton@sina.com>
Cc: dhowells@redhat.com, netdev@vger.kernel.org,
marc.dionne@auristor.com, linux-afs@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] rxrpc: Fix lack of conn cleanup when local endpoint is cleaned up [ver #2]
Date: Sun, 01 Sep 2019 08:14:56 +0100 [thread overview]
Message-ID: <14576.1567322096@warthog.procyon.org.uk> (raw)
In-Reply-To: <20190901020519.2392-1-hdanton@sina.com>
Hillf Danton <hdanton@sina.com> wrote:
> > It's certainly possible that that can happen. The reaper is per
> > network-namespace.
> >
> > conn->params.local holds a ref on the local endpoint.
> >
> Then local endpoint can not become dead without connection reaper
> running first, because of the ref held by connection. When it is
> dead, however, there is no need to run reaper directly (rather than
> through a workqueue).
The reaper is per-net_ns, not per-local. There may be more than one local
endpoint in a net_ns and they share the list of service connections.
David
next prev parent reply other threads:[~2019-09-01 7:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190831135906.6028-1-hdanton@sina.com>
2019-08-31 16:45 ` [PATCH net] rxrpc: Fix lack of conn cleanup when local endpoint is cleaned up [ver #2] David Howells
[not found] ` <20190901020519.2392-1-hdanton@sina.com>
2019-09-01 7:14 ` David Howells [this message]
2019-08-29 13:12 David Howells
2019-08-30 22:07 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14576.1567322096@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=hdanton@sina.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.dionne@auristor.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox