From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Decotigny Subject: [ethtool PATCH v4 02/11] ethtool.c: don't ignore fread() return value Date: Fri, 11 Mar 2016 09:58:15 -0800 Message-ID: <1457719104-39188-3-git-send-email-ddecotig@gmail.com> References: <1457719104-39188-1-git-send-email-ddecotig@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Jeff Garzik , Ben Hutchings , David Miller , Vidya Sagar Ravipati , Joe Perches , David Decotigny To: netdev@vger.kernel.org Return-path: Received: from mail-pa0-f66.google.com ([209.85.220.66]:33695 "EHLO mail-pa0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750833AbcCKR6i (ORCPT ); Fri, 11 Mar 2016 12:58:38 -0500 Received: by mail-pa0-f66.google.com with SMTP id q6so9056807pav.0 for ; Fri, 11 Mar 2016 09:58:38 -0800 (PST) In-Reply-To: <1457719104-39188-1-git-send-email-ddecotig@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: =46rom: David Decotigny This addresses: ethtool.c:1116:8: warning: ignoring return value of =E2=80=98fread=E2= =80=99, declared with attribute warn_unused_result [-Wunused-result] Signed-off-by: David Decotigny --- ethtool.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/ethtool.c b/ethtool.c index 92c40b8..9f80d5f 100644 --- a/ethtool.c +++ b/ethtool.c @@ -1007,6 +1007,7 @@ static int dump_regs(int gregs_dump_raw, int greg= s_dump_hex, if (gregs_dump_file) { FILE *f =3D fopen(gregs_dump_file, "r"); struct stat st; + size_t nread; =20 if (!f || fstat(fileno(f), &st) < 0) { fprintf(stderr, "Can't open '%s': %s\n", @@ -1016,8 +1017,10 @@ static int dump_regs(int gregs_dump_raw, int gre= gs_dump_hex, =20 regs =3D realloc(regs, sizeof(*regs) + st.st_size); regs->len =3D st.st_size; - fread(regs->data, regs->len, 1, f); + nread =3D fread(regs->data, regs->len, 1, f); fclose(f); + if (nread !=3D 1) + return -1; } =20 if (!gregs_dump_hex) --=20 2.7.0.rc3.207.g0ac5344