From: Joe Perches <joe@perches.com>
To: Cosmin-Gabriel Samoila <gabrielcsmo@gmail.com>, isdn@linux-pingi.de
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] isdn: hisax: isac: fixed code style issues.
Date: Sun, 13 Mar 2016 12:31:33 -0700 [thread overview]
Message-ID: <1457897493.11972.55.camel@perches.com> (raw)
In-Reply-To: <1457896913-5406-1-git-send-email-gabrielcsmo@gmail.com>
On Sun, 2016-03-13 at 21:21 +0200, Cosmin-Gabriel Samoila wrote:
> Fixed errors and warnings reported by checkpatch.pl.
Generally it's better to send multiple patches that each
change a specific type of style defect.
As is, this patch changes object code.
Fixing style inconsistency should not do that.
> diff --git a/drivers/isdn/hisax/isac.c b/drivers/isdn/hisax/isac.c
[]
> @@ -24,9 +24,8 @@
> #define DBUSY_TIMER_VALUE 80
> #define ARCOFI_USE 1
>
> -static char *ISACVer[] =
> -{"2086/2186 V1.1", "2085 B1", "2085 B2",
> - "2085 V2.3"};
> +static char *ISACVer[] = {"2086/2186 V1.1", "2085 B1", "2085 B2",
> +"2085 V2.3"};
Most common kernel style would use:
static const char *ISACVer[] = {
"2086/2186 V1.1", "2085 B1", "2085 B2", "2085 V2.3"
};
> @@ -251,11 +252,12 @@ isac_interrupt(struct IsdnCardState *cs, u_char val)
> cs->tx_skb = NULL;
> }
> }
> - if ((cs->tx_skb = skb_dequeue(&cs->sq))) {
> + cs->tx_skb = skb_dequeue(&cs->sq);
> + if (cs->tx_skb) {
> cs->tx_cnt = 0;
> isac_fill_fifo(cs);
> - } else
> - schedule_event(cs, D_XMTBUFREADY);
> + }
> + schedule_event(cs, D_XMTBUFREADY);
This changes object code.
next prev parent reply other threads:[~2016-03-13 19:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-13 19:21 [PATCH 2/2] isdn: hisax: isac: fixed code style issues Cosmin-Gabriel Samoila
2016-03-13 19:31 ` Joe Perches [this message]
2016-03-13 19:56 ` Daniel Baluta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1457897493.11972.55.camel@perches.com \
--to=joe@perches.com \
--cc=gabrielcsmo@gmail.com \
--cc=isdn@linux-pingi.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox