* [PATCH] brcmfmac: sdio: remove unused variable retry_limit
@ 2016-03-20 17:34 Colin King
2016-03-28 4:16 ` Julian Calaby
2016-04-06 18:43 ` Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Colin King @ 2016-03-20 17:34 UTC (permalink / raw)
To: Brett Rudley, Arend van Spriel, Franky Lin, Hante Meuleman,
Kalle Valo, Pieter-Paul Giesberts, Vineet Gupta, Kosuke Tatsukawa,
linux-wireless, brcm80211-dev-list, netdev
Cc: linux-kernel
From: Colin Ian King <colin.king@canonical.com>
retry_limit has never been used during the life of this driver, so
we may as well remove it as it is redundant.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
index 43fd3f4..cd92ba7 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
@@ -535,9 +535,6 @@ static int qcount[NUMPRIO];
#define RETRYCHAN(chan) ((chan) == SDPCM_EVENT_CHANNEL)
-/* Retry count for register access failures */
-static const uint retry_limit = 2;
-
/* Limit on rounding up frames */
static const uint max_roundup = 512;
--
2.7.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] brcmfmac: sdio: remove unused variable retry_limit
2016-03-20 17:34 [PATCH] brcmfmac: sdio: remove unused variable retry_limit Colin King
@ 2016-03-28 4:16 ` Julian Calaby
2016-04-06 18:43 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Julian Calaby @ 2016-03-28 4:16 UTC (permalink / raw)
To: Colin King
Cc: Brett Rudley, Arend van Spriel, Franky Lin, Hante Meuleman,
Kalle Valo, Pieter-Paul Giesberts, Vineet Gupta, Kosuke Tatsukawa,
linux-wireless, brcm80211 development, netdev,
linux-kernel@vger.kernel.org
Hi All,
On Mon, Mar 21, 2016 at 4:34 AM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> retry_limit has never been used during the life of this driver, so
> we may as well remove it as it is redundant.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Looks right to me.
Reviewed-by: Julian Calaby <julian.calaby@gmail.com>
> ---
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
> index 43fd3f4..cd92ba7 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
> @@ -535,9 +535,6 @@ static int qcount[NUMPRIO];
>
> #define RETRYCHAN(chan) ((chan) == SDPCM_EVENT_CHANNEL)
>
> -/* Retry count for register access failures */
> -static const uint retry_limit = 2;
> -
> /* Limit on rounding up frames */
> static const uint max_roundup = 512;
>
> --
> 2.7.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Julian Calaby
Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: brcmfmac: sdio: remove unused variable retry_limit
2016-03-20 17:34 [PATCH] brcmfmac: sdio: remove unused variable retry_limit Colin King
2016-03-28 4:16 ` Julian Calaby
@ 2016-04-06 18:43 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2016-04-06 18:43 UTC (permalink / raw)
To: Colin Ian King
Cc: Brett Rudley, Arend van Spriel, Franky Lin, Hante Meuleman,
Pieter-Paul Giesberts, Vineet Gupta, Kosuke Tatsukawa,
linux-wireless, brcm80211-dev-list, netdev, linux-kernel
> From: Colin Ian King <colin.king@canonical.com>
>
> retry_limit has never been used during the life of this driver, so
> we may as well remove it as it is redundant.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> Reviewed-by: Julian Calaby <julian.calaby@gmail.com>
Thanks, applied to wireless-drivers-next.git.
Kalle Valo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-04-06 18:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-20 17:34 [PATCH] brcmfmac: sdio: remove unused variable retry_limit Colin King
2016-03-28 4:16 ` Julian Calaby
2016-04-06 18:43 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).