From: Adam Seering <adam@seering.org>
To: David Miller <davem@davemloft.net>
Cc: acme@ghostprotocols.net, netdev@vger.kernel.org
Subject: Re: [PATCH] appletalk: Pass IP-over-DDP packets through when 'ipddp0' interface is not present
Date: Sun, 20 Mar 2016 17:19:52 -0400 [thread overview]
Message-ID: <1458508792.3317.16.camel@seering.org> (raw)
In-Reply-To: <1456447597.4577.49.camel@seering.org>
On Thu, 2016-02-25 at 19:46 -0500, Adam Seering wrote:
> On Thu, 2016-02-25 at 14:33 -0500, David Miller wrote:
> > From: Adam Seering <adam@seering.org>
> > Date: Tue, 23 Feb 2016 09:19:13 -0500
> >
> > > Let userspace programs transmit and receive raw IP-over-DDP
> > > packets
> > > with a kernel where "ipddp" was compiled as a module but is not
> > loaded
> > > (so no "ipddp0" network interface is exposed). This makes the
> > "module
> > > is not loaded" behavior match the "module was never compiled"
> > behavior.
> > >
> > > Signed-off-by: Adam Seering <adam@seering.org>
> >
> > I think a better approache is to somehow autoload the module.
>
> Could you elaborate? Specifically: the kernel currently suppresses
> packets on behalf of the module even after the module is unloaded.
> How
> would autoloading the module help with that?
>
I realize and appreciate that I'm not supposed to nag you folks for
feedback. But I don't know how to proceed. So, rather than nag you,
I've filed a bug:
https://bugzilla.kernel.org/show_bug.cgi?id=115031
I've tested my patch; I believe it to be the simplest change that
resolves this bug. I'm happy to write something else if it would be
cleaner and/or help others, but I would need a more-detailed
explanation of what you're looking for.
I've also filed a ticket downstream: Red Hat appears to not build the
ipddp module with their stock kernel release, so their users don't hit
this bug. But Ubuntu does build/ship ipddp; if they likewise didn't,
that would also solve my problem:
https://bugs.launchpad.net/ubuntu/+source/linux-lts-wily/+bug/1559772
Adam
next prev parent reply other threads:[~2016-03-20 21:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-23 14:19 [PATCH] appletalk: Pass IP-over-DDP packets through when 'ipddp0' interface is not present Adam Seering
2016-02-25 19:33 ` David Miller
2016-02-26 0:46 ` Adam Seering
2016-02-27 4:49 ` Adam Seering
2016-03-20 21:19 ` Adam Seering [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-01-15 4:40 Adam Seering
2016-01-18 0:25 ` David Miller
2016-01-18 1:16 ` Adam Seering
2016-01-18 5:04 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1458508792.3317.16.camel@seering.org \
--to=adam@seering.org \
--cc=acme@ghostprotocols.net \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).