From: Corcodel Marian <asd@marian1000.go.ro>
To: netdev@vger.kernel.org
Cc: Francois Romieu <romieu@fr.zoreil.com>,
Corcodel Marian <asd@marian1000.go.ro>
Subject: [PATCH 1/2 net-next v3.16]r8169: Disable set bit multicast enable per multicast address.
Date: Sat, 26 Mar 2016 12:57:00 +0200 [thread overview]
Message-ID: <1458989821-19782-1-git-send-email-asd@marian1000.go.ro> (raw)
This patch correct set bit multicast enable only once per set_rx_mode
invocation.
Signed-off-by: Corcodel Marian <asd@marian1000.go.ro>
---
drivers/net/ethernet/realtek/r8169.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
index 7f6fb1f..f7b0dfb 100644
--- a/drivers/net/ethernet/realtek/r8169.c
+++ b/drivers/net/ethernet/realtek/r8169.c
@@ -4619,12 +4619,11 @@ static void rtl_set_rx_mode(struct net_device *dev)
} else {
struct netdev_hw_addr *ha;
- rx_mode = AcceptBroadcast | AcceptMyPhys;
+ rx_mode = AcceptBroadcast | AcceptMyPhys | AcceptMulticast;
mc_filter[1] = mc_filter[0] = 0;
netdev_for_each_mc_addr(ha, dev) {
int bit_nr = ether_crc(ETH_ALEN, ha->addr) >> 26;
mc_filter[bit_nr >> 5] |= 1 << (bit_nr & 31);
- rx_mode |= AcceptMulticast;
}
}
--
2.1.4
next reply other threads:[~2016-03-26 11:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-26 10:57 Corcodel Marian [this message]
2016-03-26 10:57 ` [PATCH 2/2 net-next v3.16]r9169: Search for registers on set_rx_mode Corcodel Marian
2016-03-26 17:18 ` [PATCH 1/2 net-next v3.16]r8169: Disable set bit multicast enable per multicast address Eric Dumazet
2016-03-27 16:31 ` Corcodel Marian
2016-03-29 12:59 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1458989821-19782-1-git-send-email-asd@marian1000.go.ro \
--to=asd@marian1000.go.ro \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox