netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Grumbach, Emmanuel" <emmanuel.grumbach@intel.com>
To: linuxwifi <linuxwifi@intel.com>,
	"colin.king@canonical.com" <colin.king@canonical.com>,
	"kvalo@codeaurora.org" <kvalo@codeaurora.org>,
	"Sharon, Sara" <sara.sharon@intel.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"Berg, Johannes" <johannes.berg@intel.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] iwlwifi: pcie: remove duplicate assignment of variable isr_stats
Date: Mon, 28 Mar 2016 11:39:14 +0000	[thread overview]
Message-ID: <1459165154.9638.3.camel@intel.com> (raw)
In-Reply-To: <1459164824-6994-1-git-send-email-colin.king@canonical.com>

On Mon, 2016-03-28 at 12:33 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> isr_stats is written twice with the same value, remove one of the
> redundant assignments to isr_stats.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---


Applied - thanks.

>  drivers/net/wireless/intel/iwlwifi/pcie/rx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/rx.c
> b/drivers/net/wireless/intel/iwlwifi/pcie/rx.c
> index 4be3c35..253e4f0 100644
> --- a/drivers/net/wireless/intel/iwlwifi/pcie/rx.c
> +++ b/drivers/net/wireless/intel/iwlwifi/pcie/rx.c
> @@ -1805,7 +1805,7 @@ irqreturn_t iwl_pcie_irq_msix_handler(int irq,
> void *dev_id)
>  	struct msix_entry *entry = dev_id;
>  	struct iwl_trans_pcie *trans_pcie =
> iwl_pcie_get_trans_pcie(entry);
>  	struct iwl_trans *trans = trans_pcie->trans;
> -	struct isr_statistics *isr_stats = isr_stats = &trans_pcie
> ->isr_stats;
> +	struct isr_statistics *isr_stats = &trans_pcie->isr_stats;
>  	u32 inta_fh, inta_hw;
>  
>  	lock_map_acquire(&trans->sync_cmd_lockdep_map);

      reply	other threads:[~2016-03-28 11:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-28 11:33 [PATCH] iwlwifi: pcie: remove duplicate assignment of variable isr_stats Colin King
2016-03-28 11:39 ` Grumbach, Emmanuel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1459165154.9638.3.camel@intel.com \
    --to=emmanuel.grumbach@intel.com \
    --cc=colin.king@canonical.com \
    --cc=johannes.berg@intel.com \
    --cc=kvalo@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linuxwifi@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=sara.sharon@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).