* [PATCH] iwlwifi: pcie: remove duplicate assignment of variable isr_stats
@ 2016-03-28 11:33 Colin King
2016-03-28 11:39 ` Grumbach, Emmanuel
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2016-03-28 11:33 UTC (permalink / raw)
To: Johannes Berg, Emmanuel Grumbach, Intel Linux Wireless,
Kalle Valo, Sara Sharon, linux-wireless-u79uwXL29TY76Z2rM5mHXA,
netdev-u79uwXL29TY76Z2rM5mHXA
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA
From: Colin Ian King <colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
isr_stats is written twice with the same value, remove one of the
redundant assignments to isr_stats.
Signed-off-by: Colin Ian King <colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
---
drivers/net/wireless/intel/iwlwifi/pcie/rx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/rx.c b/drivers/net/wireless/intel/iwlwifi/pcie/rx.c
index 4be3c35..253e4f0 100644
--- a/drivers/net/wireless/intel/iwlwifi/pcie/rx.c
+++ b/drivers/net/wireless/intel/iwlwifi/pcie/rx.c
@@ -1805,7 +1805,7 @@ irqreturn_t iwl_pcie_irq_msix_handler(int irq, void *dev_id)
struct msix_entry *entry = dev_id;
struct iwl_trans_pcie *trans_pcie = iwl_pcie_get_trans_pcie(entry);
struct iwl_trans *trans = trans_pcie->trans;
- struct isr_statistics *isr_stats = isr_stats = &trans_pcie->isr_stats;
+ struct isr_statistics *isr_stats = &trans_pcie->isr_stats;
u32 inta_fh, inta_hw;
lock_map_acquire(&trans->sync_cmd_lockdep_map);
--
2.7.4
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] iwlwifi: pcie: remove duplicate assignment of variable isr_stats
2016-03-28 11:33 [PATCH] iwlwifi: pcie: remove duplicate assignment of variable isr_stats Colin King
@ 2016-03-28 11:39 ` Grumbach, Emmanuel
0 siblings, 0 replies; 2+ messages in thread
From: Grumbach, Emmanuel @ 2016-03-28 11:39 UTC (permalink / raw)
To: linuxwifi, colin.king@canonical.com, kvalo@codeaurora.org,
Sharon, Sara, netdev@vger.kernel.org, Berg, Johannes,
linux-wireless@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
On Mon, 2016-03-28 at 12:33 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> isr_stats is written twice with the same value, remove one of the
> redundant assignments to isr_stats.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
Applied - thanks.
> drivers/net/wireless/intel/iwlwifi/pcie/rx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/rx.c
> b/drivers/net/wireless/intel/iwlwifi/pcie/rx.c
> index 4be3c35..253e4f0 100644
> --- a/drivers/net/wireless/intel/iwlwifi/pcie/rx.c
> +++ b/drivers/net/wireless/intel/iwlwifi/pcie/rx.c
> @@ -1805,7 +1805,7 @@ irqreturn_t iwl_pcie_irq_msix_handler(int irq,
> void *dev_id)
> struct msix_entry *entry = dev_id;
> struct iwl_trans_pcie *trans_pcie =
> iwl_pcie_get_trans_pcie(entry);
> struct iwl_trans *trans = trans_pcie->trans;
> - struct isr_statistics *isr_stats = isr_stats = &trans_pcie
> ->isr_stats;
> + struct isr_statistics *isr_stats = &trans_pcie->isr_stats;
> u32 inta_fh, inta_hw;
>
> lock_map_acquire(&trans->sync_cmd_lockdep_map);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-03-28 11:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-28 11:33 [PATCH] iwlwifi: pcie: remove duplicate assignment of variable isr_stats Colin King
2016-03-28 11:39 ` Grumbach, Emmanuel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).