* [PATCH] fec: Do not access unexisting register in Coldfire
@ 2016-03-31 15:05 Fabio Estevam
2016-03-31 20:46 ` David Miller
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Fabio Estevam @ 2016-03-31 15:05 UTC (permalink / raw)
To: davem; +Cc: fugang.duan, troy.kisky, gerg, netdev, Fabio Estevam
From: Fabio Estevam <fabio.estevam@nxp.com>
Commit 55cd48c821de ("net: fec: stop the "rcv is not +last, " error
messages") introduces a write to a register that does not exist in
Coldfire.
Move the FEC_FTRL register access inside the FEC_QUIRK_HAS_RACC 'if' block,
so that we guarantee it will not be used on Coldfire CPUs.
Reported-by: Greg Ungerer <gerg@uclinux.org>
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
drivers/net/ethernet/freescale/fec_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
index 37c0815..08243c2 100644
--- a/drivers/net/ethernet/freescale/fec_main.c
+++ b/drivers/net/ethernet/freescale/fec_main.c
@@ -943,8 +943,8 @@ fec_restart(struct net_device *ndev)
else
val &= ~FEC_RACC_OPTIONS;
writel(val, fep->hwp + FEC_RACC);
+ writel(PKT_MAXBUF_SIZE, fep->hwp + FEC_FTRL);
}
- writel(PKT_MAXBUF_SIZE, fep->hwp + FEC_FTRL);
#endif
/*
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] fec: Do not access unexisting register in Coldfire
2016-03-31 15:05 [PATCH] fec: Do not access unexisting register in Coldfire Fabio Estevam
@ 2016-03-31 20:46 ` David Miller
2016-03-31 23:43 ` Greg Ungerer
2016-04-01 1:39 ` Fugang Duan
2 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2016-03-31 20:46 UTC (permalink / raw)
To: festevam; +Cc: fugang.duan, troy.kisky, gerg, netdev, fabio.estevam
From: Fabio Estevam <festevam@gmail.com>
Date: Thu, 31 Mar 2016 12:05:17 -0300
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> Commit 55cd48c821de ("net: fec: stop the "rcv is not +last, " error
> messages") introduces a write to a register that does not exist in
> Coldfire.
>
> Move the FEC_FTRL register access inside the FEC_QUIRK_HAS_RACC 'if' block,
> so that we guarantee it will not be used on Coldfire CPUs.
>
> Reported-by: Greg Ungerer <gerg@uclinux.org>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] fec: Do not access unexisting register in Coldfire
2016-03-31 15:05 [PATCH] fec: Do not access unexisting register in Coldfire Fabio Estevam
2016-03-31 20:46 ` David Miller
@ 2016-03-31 23:43 ` Greg Ungerer
2016-04-01 1:39 ` Fugang Duan
2 siblings, 0 replies; 4+ messages in thread
From: Greg Ungerer @ 2016-03-31 23:43 UTC (permalink / raw)
To: Fabio Estevam, davem; +Cc: fugang.duan, troy.kisky, netdev, Fabio Estevam
Thanks for taking care of that Fabio.
Regards
Greg
On 01/04/16 01:05, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> Commit 55cd48c821de ("net: fec: stop the "rcv is not +last, " error
> messages") introduces a write to a register that does not exist in
> Coldfire.
>
> Move the FEC_FTRL register access inside the FEC_QUIRK_HAS_RACC 'if' block,
> so that we guarantee it will not be used on Coldfire CPUs.
>
> Reported-by: Greg Ungerer <gerg@uclinux.org>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
> drivers/net/ethernet/freescale/fec_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
> index 37c0815..08243c2 100644
> --- a/drivers/net/ethernet/freescale/fec_main.c
> +++ b/drivers/net/ethernet/freescale/fec_main.c
> @@ -943,8 +943,8 @@ fec_restart(struct net_device *ndev)
> else
> val &= ~FEC_RACC_OPTIONS;
> writel(val, fep->hwp + FEC_RACC);
> + writel(PKT_MAXBUF_SIZE, fep->hwp + FEC_FTRL);
> }
> - writel(PKT_MAXBUF_SIZE, fep->hwp + FEC_FTRL);
> #endif
>
> /*
>
^ permalink raw reply [flat|nested] 4+ messages in thread* RE: [PATCH] fec: Do not access unexisting register in Coldfire
2016-03-31 15:05 [PATCH] fec: Do not access unexisting register in Coldfire Fabio Estevam
2016-03-31 20:46 ` David Miller
2016-03-31 23:43 ` Greg Ungerer
@ 2016-04-01 1:39 ` Fugang Duan
2 siblings, 0 replies; 4+ messages in thread
From: Fugang Duan @ 2016-04-01 1:39 UTC (permalink / raw)
To: Fabio Estevam, davem@davemloft.net
Cc: troy.kisky@boundarydevices.com, gerg@uclinux.org,
netdev@vger.kernel.org, Fabio Estevam
From: Fabio Estevam <festevam@gmail.com> Sent: Thursday, March 31, 2016 11:05 PM
> To: davem@davemloft.net
> Cc: Fugang Duan <fugang.duan@nxp.com>; troy.kisky@boundarydevices.com;
> gerg@uclinux.org; netdev@vger.kernel.org; Fabio Estevam
> <fabio.estevam@nxp.com>
> Subject: [PATCH] fec: Do not access unexisting register in Coldfire
>
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> Commit 55cd48c821de ("net: fec: stop the "rcv is not +last, " error
> messages") introduces a write to a register that does not exist in Coldfire.
>
> Move the FEC_FTRL register access inside the FEC_QUIRK_HAS_RACC 'if' block,
> so that we guarantee it will not be used on Coldfire CPUs.
>
> Reported-by: Greg Ungerer <gerg@uclinux.org>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
> drivers/net/ethernet/freescale/fec_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/freescale/fec_main.c
> b/drivers/net/ethernet/freescale/fec_main.c
> index 37c0815..08243c2 100644
> --- a/drivers/net/ethernet/freescale/fec_main.c
> +++ b/drivers/net/ethernet/freescale/fec_main.c
> @@ -943,8 +943,8 @@ fec_restart(struct net_device *ndev)
> else
> val &= ~FEC_RACC_OPTIONS;
> writel(val, fep->hwp + FEC_RACC);
> + writel(PKT_MAXBUF_SIZE, fep->hwp + FEC_FTRL);
> }
> - writel(PKT_MAXBUF_SIZE, fep->hwp + FEC_FTRL);
> #endif
>
> /*
> --
> 1.9.1
If you stick to do it like this, you must add comments on the quirk flag FEC_QUIRK_HAS_RACC.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-04-01 1:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-31 15:05 [PATCH] fec: Do not access unexisting register in Coldfire Fabio Estevam
2016-03-31 20:46 ` David Miller
2016-03-31 23:43 ` Greg Ungerer
2016-04-01 1:39 ` Fugang Duan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).