[PATCH] bridge: remove br_dev_set_multicast_list

[PATCH] bridge: remove br_dev_set_multicast_list

[roy.qing.li]

From: Li RongQing <roy.qing.li@gmail.com>

remove br_dev_set_multicast_list which does nothing

Signed-off-by: Li RongQing <roy.qing.li@gmail.com>
---
 net/bridge/br_device.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/net/bridge/br_device.c b/net/bridge/br_device.c
index 2c8095a..75c7e00 100644
--- a/net/bridge/br_device.c
+++ b/net/bridge/br_device.c
@@ -123,10 +123,6 @@ static int br_dev_open(struct net_device *dev)
 	return 0;
 }
 
-static void br_dev_set_multicast_list(struct net_device *dev)
-{
-}
-
 static void br_dev_change_rx_flags(struct net_device *dev, int change)
 {
 	if (change & IFF_PROMISC)
@@ -329,7 +325,6 @@ static const struct net_device_ops br_netdev_ops = {
 	.ndo_start_xmit		 = br_dev_xmit,
 	.ndo_get_stats64	 = br_get_stats64,
 	.ndo_set_mac_address	 = br_set_mac_address,
-	.ndo_set_rx_mode	 = br_dev_set_multicast_list,
 	.ndo_change_rx_flags	 = br_dev_change_rx_flags,
 	.ndo_change_mtu		 = br_change_mtu,
 	.ndo_do_ioctl		 = br_dev_ioctl,
-- 
2.1.4

Re: [PATCH] bridge: remove br_dev_set_multicast_list

[David Miller]

From: roy.qing.li@gmail.com
Date: Fri,  1 Apr 2016 16:16:10 +0800

> From: Li RongQing <roy.qing.li@gmail.com>
> 
> remove br_dev_set_multicast_list which does nothing
> 
> Signed-off-by: Li RongQing <roy.qing.li@gmail.com>

This will break SIOCADDMULTI et al. on the bridge, see net/core/dev.c
which checks whether this ndo OP is NULL or not.

Please sufficiently grep the source tree on how an ndo operation is
used before making changes like this.

Thanks.