From: Shamir Rabinovitch <shamir.rabinovitch@oracle.com>
To: rds-devel@oss.oracle.com, netdev@vger.kernel.org
Cc: davem@davemloft.net, shamir.rabinovitch@oracle.com
Subject: [PATCH v3 1/2] RDS: fix "Kernel unaligned access" on sparc64
Date: Sun, 3 Apr 2016 08:24:03 -0400 [thread overview]
Message-ID: <1459686244-14939-1-git-send-email-shamir.rabinovitch@oracle.com> (raw)
Sparc64 expect 64 bit types to be aligned to 8. This patch ensure that
memory allocated by 'rds_page_remainder_alloc' will be aligned to 8.
This patch fix issue found in 'rds_ib_cong_recv' when accessing
unaligned memory using uint64_t pointer.
Signed-off-by: Shamir Rabinovitch <shamir.rabinovitch@oracle.com>
Reviewed-by: Wengang Wang <wen.gang.wang@oracle.com>
Reviewed-by: Ajaykumar Hotchandani <ajaykumar.hotchandani@oracle.com>
Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
Tested-by: Anand Bibhuti <anand.bibhuti@oracle.com>
---
net/rds/page.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/net/rds/page.c b/net/rds/page.c
index 616f21f..4813e1f 100644
--- a/net/rds/page.c
+++ b/net/rds/page.c
@@ -135,8 +135,9 @@ int rds_page_remainder_alloc(struct scatterlist *scat, unsigned long bytes,
if (rem->r_offset != 0)
rds_stats_inc(s_page_remainder_hit);
- rem->r_offset += bytes;
- if (rem->r_offset == PAGE_SIZE) {
+ /* fix 'Kernel unaligned access' on sparc64 */
+ rem->r_offset += ALIGN(bytes, 8);
+ if (rem->r_offset >= PAGE_SIZE) {
__free_page(rem->r_page);
rem->r_page = NULL;
}
--
1.7.1
next reply other threads:[~2016-04-03 12:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-03 12:24 Shamir Rabinovitch [this message]
2016-04-03 12:24 ` [PATCH v3 2/2] RDS: fix congestion map corruption for PAGE_SIZE > 8k Shamir Rabinovitch
2016-04-04 19:57 ` [PATCH v3 1/2] RDS: fix "Kernel unaligned access" on sparc64 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1459686244-14939-1-git-send-email-shamir.rabinovitch@oracle.com \
--to=shamir.rabinovitch@oracle.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=rds-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).