From: Hannes Frederic Sowa <hannes@stressinduktion.org>
To: David Miller <davem@davemloft.net>, fengguang.wu@intel.com
Cc: kbuild-all@01.org, netdev@vger.kernel.org
Subject: Re: [net-next:master 194/196] include/net/sock.h:1367:9: error: implicit declaration of function 'lockdep_is_held'
Date: Fri, 08 Apr 2016 00:12:07 +0200 [thread overview]
Message-ID: <1460067127.988018.572315241.7F1FE712@webmail.messagingengine.com> (raw)
In-Reply-To: <20160407.170937.292677537698351913.davem@davemloft.net>
On Thu, Apr 7, 2016, at 23:09, David Miller wrote:
> From: kbuild test robot <fengguang.wu@intel.com>
> Date: Fri, 8 Apr 2016 05:00:42 +0800
>
> > include/net/sock.h: In function 'lockdep_sock_is_held':
> >>> include/net/sock.h:1367:9: error: implicit declaration of function 'lockdep_is_held' [-Werror=implicit-function-declaration]
> > return lockdep_is_held(&sk->sk_lock) ||
> ...
> > 1361 } while (0)
> > 1362
> > 1363 static bool lockdep_sock_is_held(const struct sock *csk)
> > 1364 {
> > 1365 struct sock *sk = (struct sock *)csk;
> > 1366
> >> 1367 return lockdep_is_held(&sk->sk_lock) ||
> > 1368 lockdep_is_held(&sk->sk_lock.slock);
> > 1369 }
>
> Hmmm, Hannes to we need to make this a macro just like lockdep_is_held()
> is?
I think my newest patch should fix it. I simply forgot the inline
keyword. inline functions get invisible if not used by the compiler.
Sorry,
Hannes
prev parent reply other threads:[~2016-04-07 22:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-07 21:00 [net-next:master 194/196] include/net/sock.h:1367:9: error: implicit declaration of function 'lockdep_is_held' kbuild test robot
2016-04-07 21:09 ` David Miller
2016-04-07 22:12 ` Hannes Frederic Sowa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1460067127.988018.572315241.7F1FE712@webmail.messagingengine.com \
--to=hannes@stressinduktion.org \
--cc=davem@davemloft.net \
--cc=fengguang.wu@intel.com \
--cc=kbuild-all@01.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox