* [PATCH] drivers/net/ethernet/jme.c: Deinline jme_reset_mac_processor, save 2816 bytes
@ 2016-04-08 18:39 Denys Vlasenko
2016-04-14 2:57 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Denys Vlasenko @ 2016-04-08 18:39 UTC (permalink / raw)
To: David S. Miller; +Cc: Denys Vlasenko, linux-kernel, netdev
This function compiles to 895 bytes of machine code.
Clearly, this isn't a time-critical function.
For one, it has a number of udelay(1) calls.
Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
CC: David S. Miller <davem@davemloft.net>
CC: linux-kernel@vger.kernel.org
CC: netdev@vger.kernel.org
---
drivers/net/ethernet/jme.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/jme.c b/drivers/net/ethernet/jme.c
index 3ddf657..711cb19 100644
--- a/drivers/net/ethernet/jme.c
+++ b/drivers/net/ethernet/jme.c
@@ -222,7 +222,7 @@ jme_clear_ghc_reset(struct jme_adapter *jme)
jwrite32f(jme, JME_GHC, jme->reg_ghc);
}
-static inline void
+static void
jme_reset_mac_processor(struct jme_adapter *jme)
{
static const u32 mask[WAKEUP_FRAME_MASK_DWNR] = {0, 0, 0, 0};
--
2.1.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drivers/net/ethernet/jme.c: Deinline jme_reset_mac_processor, save 2816 bytes
2016-04-08 18:39 [PATCH] drivers/net/ethernet/jme.c: Deinline jme_reset_mac_processor, save 2816 bytes Denys Vlasenko
@ 2016-04-14 2:57 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2016-04-14 2:57 UTC (permalink / raw)
To: dvlasenk; +Cc: linux-kernel, netdev
From: Denys Vlasenko <dvlasenk@redhat.com>
Date: Fri, 8 Apr 2016 20:39:47 +0200
> This function compiles to 895 bytes of machine code.
>
> Clearly, this isn't a time-critical function.
> For one, it has a number of udelay(1) calls.
>
> Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
No x.c file should be using inline anyways, applied to net-next,
thanks a lot!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-04-14 2:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-08 18:39 [PATCH] drivers/net/ethernet/jme.c: Deinline jme_reset_mac_processor, save 2816 bytes Denys Vlasenko
2016-04-14 2:57 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).