netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sinan Kaya <okaya@codeaurora.org>
To: linux-rdma@vger.kernel.org, timur@codeaurora.org, cov@codeaurora.org
Cc: Sinan Kaya <okaya@codeaurora.org>,
	Yishai Hadas <yishaih@mellanox.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH V2] net: ethernet: mellanox: correct page conversion
Date: Sat, 16 Apr 2016 18:23:32 -0400	[thread overview]
Message-ID: <1460845412-13120-1-git-send-email-okaya@codeaurora.org> (raw)

Current code is assuming that the address returned by dma_alloc_coherent
is a logical address. This is not true on ARM/ARM64 systems. This patch
replaces dma_alloc_coherent with dma_map_page API. The address returned
can later by virtually mapped from the CPU side with vmap API.

Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
---
 drivers/net/ethernet/mellanox/mlx4/alloc.c | 37 ++++++++++++++++++++++--------
 1 file changed, 27 insertions(+), 10 deletions(-)

diff --git a/drivers/net/ethernet/mellanox/mlx4/alloc.c b/drivers/net/ethernet/mellanox/mlx4/alloc.c
index 0c51c69..22a7ae7 100644
--- a/drivers/net/ethernet/mellanox/mlx4/alloc.c
+++ b/drivers/net/ethernet/mellanox/mlx4/alloc.c
@@ -618,13 +618,26 @@ int mlx4_buf_alloc(struct mlx4_dev *dev, int size, int max_direct,
 			return -ENOMEM;
 
 		for (i = 0; i < buf->nbufs; ++i) {
-			buf->page_list[i].buf =
-				dma_alloc_coherent(&dev->persist->pdev->dev,
-						   PAGE_SIZE,
-						   &t, gfp);
-			if (!buf->page_list[i].buf)
+			struct page *page;
+
+			page = alloc_page(GFP_KERNEL);
+			if (!page)
 				goto err_free;
 
+			t = dma_map_page(&dev->persist->pdev->dev, page, 0,
+					 PAGE_SIZE, DMA_BIDIRECTIONAL);
+
+			if (dma_mapping_error(&dev->persist->pdev->dev, t)) {
+				__free_page(page);
+				goto err_free;
+			}
+
+			buf->page_list[i].buf = page_address(page);
+			if (!buf->page_list[i].buf) {
+				__free_page(page);
+				goto err_free;
+			}
+
 			buf->page_list[i].map = t;
 
 			memset(buf->page_list[i].buf, 0, PAGE_SIZE);
@@ -666,11 +679,15 @@ void mlx4_buf_free(struct mlx4_dev *dev, int size, struct mlx4_buf *buf)
 			vunmap(buf->direct.buf);
 
 		for (i = 0; i < buf->nbufs; ++i)
-			if (buf->page_list[i].buf)
-				dma_free_coherent(&dev->persist->pdev->dev,
-						  PAGE_SIZE,
-						  buf->page_list[i].buf,
-						  buf->page_list[i].map);
+			if (buf->page_list[i].buf) {
+				struct page *page;
+
+				page = virt_to_page(buf->page_list[i].buf);
+				dma_unmap_page(&dev->persist->pdev->dev,
+					       buf->page_list[i].map,
+					       PAGE_SIZE, DMA_BIDIRECTIONAL);
+				__free_page(page);
+			}
 		kfree(buf->page_list);
 	}
 }
-- 
1.8.2.1

             reply	other threads:[~2016-04-16 22:23 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-16 22:23 Sinan Kaya [this message]
2016-04-18  6:54 ` [PATCH V2] net: ethernet: mellanox: correct page conversion Eli Cohen
2016-04-18 13:53   ` Sinan Kaya
2016-04-18 14:05     ` Eli Cohen
2016-04-18 14:32   ` Christoph Hellwig
2016-04-18 14:39     ` Eli Cohen
     [not found]       ` <DB5PR05MB1848424EC9DC8D4150EADB03C56B0-8IvNv+8VlcDdorXcTtKhldqRiQSDpxhJvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2016-04-18 15:17         ` Christoph Hellwig
     [not found]           ` <20160418151702.GA26565-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2016-04-18 15:21             ` Sinan Kaya
     [not found]               ` <5714FB68.3020604-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-04-18 15:40                 ` Christoph Hellwig
2016-04-18 17:47                   ` Sinan Kaya
2016-04-19  7:50                   ` Sinan Kaya
     [not found] ` <1460845412-13120-1-git-send-email-okaya-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-04-18  4:00   ` David Miller
2016-04-18  5:06     ` okaya
     [not found]       ` <87c17d3f979cf0167cd37077f39d0534-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-04-18 15:59         ` David Miller
     [not found]           ` <20160418.115902.1053705461620271779.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2016-04-18 16:06             ` Sinan Kaya
2016-04-18 12:12   ` Christoph Hellwig
2016-04-18 13:06     ` okaya
2016-04-18 13:10       ` Christoph Hellwig
2016-04-18 13:49         ` Sinan Kaya
2016-04-18 13:59           ` Christoph Hellwig
     [not found]           ` <5714E5D6.7050600-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-04-18 15:15             ` Timur Tabi
     [not found]               ` <5714FA2C.4030209-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-04-18 15:22                 ` Sinan Kaya
2016-04-19 18:22   ` Christoph Hellwig
2016-04-19 18:37     ` Sinan Kaya
2016-04-20 11:08       ` Eran Ben Elisha
     [not found]     ` <20160419182212.GA8441-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2016-04-20 13:35       ` Sinan Kaya
     [not found]         ` <571785A5.5040306-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-04-20 13:38           ` Sinan Kaya
     [not found]             ` <57178663.4050503-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-04-20 13:41               ` Timur Tabi
2016-04-20 18:40           ` Eran Ben Elisha
     [not found]             ` <CAKHjkjmYNLABO10V1DZQmZ_zczjbfDZU0TDPHoMmv_1FMi9_gA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-04-20 18:42               ` Sinan Kaya
2016-04-21 13:37               ` Or Gerlitz
2016-04-21 13:39                 ` Christoph Hellwig
     [not found]                   ` <20160421133903.GA19633-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2016-04-21 13:45                     ` Or Gerlitz
2016-04-25 13:47                   ` Eran Ben Elisha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1460845412-13120-1-git-send-email-okaya@codeaurora.org \
    --to=okaya@codeaurora.org \
    --cc=cov@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=timur@codeaurora.org \
    --cc=yishaih@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).