netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, roopa@cumulusnetworks.com,
	eric.dumazet@gmail.com, tgraf@suug.ch, jhs@mojatatu.com,
	Nicolas Dichtel <nicolas.dichtel@6wind.com>
Subject: [PATCH net-next 3/4] ipmr: align RTA_MFC_STATS on 64-bit
Date: Wed, 20 Apr 2016 10:57:34 +0200	[thread overview]
Message-ID: <1461142655-5067-4-git-send-email-nicolas.dichtel@6wind.com> (raw)
In-Reply-To: <1461142655-5067-1-git-send-email-nicolas.dichtel@6wind.com>

Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
---
 include/uapi/linux/rtnetlink.h | 1 +
 net/ipv4/ipmr.c                | 4 ++--
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/include/uapi/linux/rtnetlink.h b/include/uapi/linux/rtnetlink.h
index ca764b5da86d..02baa5281bbf 100644
--- a/include/uapi/linux/rtnetlink.h
+++ b/include/uapi/linux/rtnetlink.h
@@ -312,6 +312,7 @@ enum rtattr_type_t {
 	RTA_ENCAP_TYPE,
 	RTA_ENCAP,
 	RTA_EXPIRES,
+	RTA_PAD,
 	__RTA_MAX
 };
 
diff --git a/net/ipv4/ipmr.c b/net/ipv4/ipmr.c
index 395e2814a46d..21a38e296fe2 100644
--- a/net/ipv4/ipmr.c
+++ b/net/ipv4/ipmr.c
@@ -2104,7 +2104,7 @@ static int __ipmr_fill_mroute(struct mr_table *mrt, struct sk_buff *skb,
 	mfcs.mfcs_packets = c->mfc_un.res.pkt;
 	mfcs.mfcs_bytes = c->mfc_un.res.bytes;
 	mfcs.mfcs_wrong_if = c->mfc_un.res.wrong_if;
-	if (nla_put(skb, RTA_MFC_STATS, sizeof(mfcs), &mfcs) < 0)
+	if (nla_put_64bit(skb, RTA_MFC_STATS, sizeof(mfcs), &mfcs, RTA_PAD) < 0)
 		return -EMSGSIZE;
 
 	rtm->rtm_type = RTN_MULTICAST;
@@ -2237,7 +2237,7 @@ static size_t mroute_msgsize(bool unresolved, int maxvif)
 		      + nla_total_size(0)	/* RTA_MULTIPATH */
 		      + maxvif * NLA_ALIGN(sizeof(struct rtnexthop))
 						/* RTA_MFC_STATS */
-		      + nla_total_size(sizeof(struct rta_mfc_stats))
+		      + nla_total_size_64bit(sizeof(struct rta_mfc_stats))
 		;
 
 	return len;
-- 
2.4.2

  parent reply	other threads:[~2016-04-20  8:57 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-18 21:10 [PATCH net-next v5] rtnetlink: add new RTM_GETSTATS message to dump link stats Roopa Prabhu
2016-04-18 21:35 ` Eric Dumazet
2016-04-19  0:57   ` David Miller
2016-04-19  1:48     ` David Miller
2016-04-19  2:22       ` Eric Dumazet
2016-04-19  2:40         ` Roopa Prabhu
2016-04-19  3:49           ` David Miller
2016-04-19  3:52       ` David Miller
2016-04-19 10:09         ` Johannes Berg
2016-04-19 10:48           ` Emmanuel Grumbach
2016-04-19 18:23           ` David Miller
2016-04-19 19:41             ` Johannes Berg
2016-04-20  1:53               ` David Ahern
2016-04-20  7:32                 ` Johannes Berg
2016-04-20 12:48                   ` Jiri Benc
2016-04-20 13:17                     ` Johannes Berg
2016-04-20 13:34                       ` Jiri Benc
2016-04-20 20:13                         ` Johannes Berg
2016-04-19  2:30     ` roopa
2016-04-19  3:41 ` David Miller
2016-04-19  4:17   ` Eric Dumazet
2016-04-19  4:32   ` Eric Dumazet
2016-04-19  5:03     ` David Miller
2016-04-19 18:31       ` David Miller
2016-04-19 18:45         ` Eric Dumazet
2016-04-19 18:47         ` Eric Dumazet
2016-04-19 19:08           ` Nicolas Dichtel
2016-04-19 23:50             ` David Miller
2016-04-20  3:54               ` Roopa Prabhu
2016-04-20  8:57               ` [PATCH net-next 0/4] libnl: enhance API to ease 64bit alignment for attribute Nicolas Dichtel
2016-04-20  8:57                 ` [PATCH net-next 1/4] netlink: fix test alignment in nla_align_64bit() Nicolas Dichtel
2016-04-20  9:33                   ` Eric Dumazet
2016-04-20  9:44                     ` Nicolas Dichtel
2016-04-20  9:57                       ` Eric Dumazet
2016-04-20 10:14                         ` Nicolas Dichtel
2016-04-20 14:31                         ` [PATCH net-next] net: fix HAVE_EFFICIENT_UNALIGNED_ACCESS typos Eric Dumazet
2016-04-20 15:03                           ` David Miller
2016-04-20  8:57                 ` [PATCH net-next 2/4] libnl: add more helpers to align attribute on 64-bit Nicolas Dichtel
2016-04-20  8:57                 ` Nicolas Dichtel [this message]
2016-04-20  8:57                 ` [PATCH net-next 4/4] ip6mr: align RTA_MFC_STATS " Nicolas Dichtel
2016-04-21 16:58                 ` [PATCH net-next v2 0/4] libnl: enhance API to ease 64bit alignment for attribute Nicolas Dichtel
2016-04-21 16:58                   ` [PATCH net-next v2 1/4] libnl: add more helpers to align attributes on 64-bit Nicolas Dichtel
2016-04-21 16:58                   ` [PATCH net-next v2 2/4] rtnl: use the new API to align IFLA_STATS* Nicolas Dichtel
2016-04-21 16:58                   ` [PATCH net-next v2 3/4] ipmr: align RTA_MFC_STATS on 64-bit Nicolas Dichtel
2016-04-21 16:58                   ` [PATCH net-next v2 4/4] ip6mr: " Nicolas Dichtel
2016-04-21 18:28                   ` [PATCH net-next v2 0/4] libnl: enhance API to ease 64bit alignment for attribute David Miller
2016-04-21 22:00                     ` Nicolas Dichtel
2016-04-22  5:31                       ` David Miller
2016-04-19 19:05         ` [PATCH net-next v5] rtnetlink: add new RTM_GETSTATS message to dump link stats Roopa Prabhu
2016-04-19 22:49           ` David Miller
2016-04-20  3:53             ` Roopa Prabhu
2016-04-19  4:43   ` Roopa Prabhu
2016-04-19  7:45   ` Nicolas Dichtel
2016-04-19 16:00     ` David Miller
2016-04-19  8:26 ` Nicolas Dichtel
2016-04-19 19:55   ` Paul Moore
2016-04-19 20:40     ` Roopa Prabhu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1461142655-5067-4-git-send-email-nicolas.dichtel@6wind.com \
    --to=nicolas.dichtel@6wind.com \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=jhs@mojatatu.com \
    --cc=netdev@vger.kernel.org \
    --cc=roopa@cumulusnetworks.com \
    --cc=tgraf@suug.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).