From: Johannes Berg <johannes@sipsolutions.net>
To: Jiri Benc <jbenc@redhat.com>
Cc: David Ahern <dsa@cumulusnetworks.com>,
David Miller <davem@davemloft.net>,
eric.dumazet@gmail.com, roopa@cumulusnetworks.com,
netdev@vger.kernel.org, jhs@mojatatu.com, tgraf@suug.ch,
nicolas.dichtel@6wind.com, egrumbach@gmail.com
Subject: Re: [PATCH net-next v5] rtnetlink: add new RTM_GETSTATS message to dump link stats
Date: Wed, 20 Apr 2016 22:13:50 +0200 [thread overview]
Message-ID: <1461183230.2176.28.camel@sipsolutions.net> (raw)
In-Reply-To: <20160420153449.5dd5fb24@griffin>
On Wed, 2016-04-20 at 15:34 +0200, Jiri Benc wrote:
> On Wed, 20 Apr 2016 15:17:08 +0200, Johannes Berg wrote:
> >
> > Looks like you have this on a per-message basis. I thought it was
> > better on an attribute basis because that's really where the issue
> > is.
> No problem. I'm not that happy with my patchset myself. Just wanted
> to point it out in case it's useful.
Yeah, I looked at it, but I think it ended up a bit too complicated
really.
It does have slightly more validation in some sense, but I don't really
think that justifies the complexity?
No matter what, we'll always have to deal with the problem of not
having this capability on older kernels. One way to work around it
would be to add a new NLM_F_REQUEST2 flag, since the kernel currently
requires having NLM_F_REQUEST set, NLM_F_REQUEST2 messages would be
rejected by existing kernels. Dunno if it's really worth it though, I
suspect that family/command-specific detection will work in practically
all cases.
johannes
next prev parent reply other threads:[~2016-04-20 20:13 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-18 21:10 [PATCH net-next v5] rtnetlink: add new RTM_GETSTATS message to dump link stats Roopa Prabhu
2016-04-18 21:35 ` Eric Dumazet
2016-04-19 0:57 ` David Miller
2016-04-19 1:48 ` David Miller
2016-04-19 2:22 ` Eric Dumazet
2016-04-19 2:40 ` Roopa Prabhu
2016-04-19 3:49 ` David Miller
2016-04-19 3:52 ` David Miller
2016-04-19 10:09 ` Johannes Berg
2016-04-19 10:48 ` Emmanuel Grumbach
2016-04-19 18:23 ` David Miller
2016-04-19 19:41 ` Johannes Berg
2016-04-20 1:53 ` David Ahern
2016-04-20 7:32 ` Johannes Berg
2016-04-20 12:48 ` Jiri Benc
2016-04-20 13:17 ` Johannes Berg
2016-04-20 13:34 ` Jiri Benc
2016-04-20 20:13 ` Johannes Berg [this message]
2016-04-19 2:30 ` roopa
2016-04-19 3:41 ` David Miller
2016-04-19 4:17 ` Eric Dumazet
2016-04-19 4:32 ` Eric Dumazet
2016-04-19 5:03 ` David Miller
2016-04-19 18:31 ` David Miller
2016-04-19 18:45 ` Eric Dumazet
2016-04-19 18:47 ` Eric Dumazet
2016-04-19 19:08 ` Nicolas Dichtel
2016-04-19 23:50 ` David Miller
2016-04-20 3:54 ` Roopa Prabhu
2016-04-20 8:57 ` [PATCH net-next 0/4] libnl: enhance API to ease 64bit alignment for attribute Nicolas Dichtel
2016-04-20 8:57 ` [PATCH net-next 1/4] netlink: fix test alignment in nla_align_64bit() Nicolas Dichtel
2016-04-20 9:33 ` Eric Dumazet
2016-04-20 9:44 ` Nicolas Dichtel
2016-04-20 9:57 ` Eric Dumazet
2016-04-20 10:14 ` Nicolas Dichtel
2016-04-20 14:31 ` [PATCH net-next] net: fix HAVE_EFFICIENT_UNALIGNED_ACCESS typos Eric Dumazet
2016-04-20 15:03 ` David Miller
2016-04-20 8:57 ` [PATCH net-next 2/4] libnl: add more helpers to align attribute on 64-bit Nicolas Dichtel
2016-04-20 8:57 ` [PATCH net-next 3/4] ipmr: align RTA_MFC_STATS " Nicolas Dichtel
2016-04-20 8:57 ` [PATCH net-next 4/4] ip6mr: " Nicolas Dichtel
2016-04-21 16:58 ` [PATCH net-next v2 0/4] libnl: enhance API to ease 64bit alignment for attribute Nicolas Dichtel
2016-04-21 16:58 ` [PATCH net-next v2 1/4] libnl: add more helpers to align attributes on 64-bit Nicolas Dichtel
2016-04-21 16:58 ` [PATCH net-next v2 2/4] rtnl: use the new API to align IFLA_STATS* Nicolas Dichtel
2016-04-21 16:58 ` [PATCH net-next v2 3/4] ipmr: align RTA_MFC_STATS on 64-bit Nicolas Dichtel
2016-04-21 16:58 ` [PATCH net-next v2 4/4] ip6mr: " Nicolas Dichtel
2016-04-21 18:28 ` [PATCH net-next v2 0/4] libnl: enhance API to ease 64bit alignment for attribute David Miller
2016-04-21 22:00 ` Nicolas Dichtel
2016-04-22 5:31 ` David Miller
2016-04-19 19:05 ` [PATCH net-next v5] rtnetlink: add new RTM_GETSTATS message to dump link stats Roopa Prabhu
2016-04-19 22:49 ` David Miller
2016-04-20 3:53 ` Roopa Prabhu
2016-04-19 4:43 ` Roopa Prabhu
2016-04-19 7:45 ` Nicolas Dichtel
2016-04-19 16:00 ` David Miller
2016-04-19 8:26 ` Nicolas Dichtel
2016-04-19 19:55 ` Paul Moore
2016-04-19 20:40 ` Roopa Prabhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1461183230.2176.28.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=davem@davemloft.net \
--cc=dsa@cumulusnetworks.com \
--cc=egrumbach@gmail.com \
--cc=eric.dumazet@gmail.com \
--cc=jbenc@redhat.com \
--cc=jhs@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=roopa@cumulusnetworks.com \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).