From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hannes Frederic Sowa Subject: Re: [PATCH net-next 0/7] net: network drivers should not depend on geneve/vxlan Date: Thu, 21 Apr 2016 09:43:11 +0200 Message-ID: <1461224591.4101216.585253121.498EBE7C@webmail.messagingengine.com> References: <1461007188-1603-1-git-send-email-hannes@stressinduktion.org> <20160419.202750.1844614056540086769.davem@davemloft.net> <1461114373.2649930.583890089.0C126826@webmail.messagingengine.com> <20160419.211134.2163748309501010595.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, jesse@kernel.org To: David Miller Return-path: Received: from out2-smtp.messagingengine.com ([66.111.4.26]:50148 "EHLO out2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751571AbcDUHnM (ORCPT ); Thu, 21 Apr 2016 03:43:12 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id CEDC220201 for ; Thu, 21 Apr 2016 03:43:11 -0400 (EDT) In-Reply-To: <20160419.211134.2163748309501010595.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: Hi David, On Wed, Apr 20, 2016, at 03:11, David Miller wrote: > From: Hannes Frederic Sowa > Date: Wed, 20 Apr 2016 03:06:13 +0200 > > > On Wed, Apr 20, 2016, at 02:27, David Miller wrote: > >> From: Hannes Frederic Sowa > >> Date: Mon, 18 Apr 2016 21:19:41 +0200 > >> > >> > This patchset removes the dependency of network drivers on vxlan or > >> > geneve, so those don't get autoloaded when the nic driver is loaded. > >> > > >> > Also audited the code such that vxlan_get_rx_port and geneve_get_rx_port > >> > are not called without rtnl lock. > >> > >> In net-next, the 'qed' driver has tunneling offload support too. > >> Don't you need to update this series to handle that driver as > >> well? > > > > I audited qede as well: > > > > qede calls {vxlan,geneve}_get_rx_port only from ndo_open which isn't > > reused anywhere else in the driver, only from ndo_open, which holds > > rtnl_lock also. Thus the driver is safe and doesn't need a change. > > I'm talking about your final patches which elide the dependencies. could you look at this again? If you have further feedback I am happy to incooperate those. Thank you, Hannes