From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: davem@davemloft.net
Cc: Sridhar Samudrala <sridhar.samudrala@intel.com>,
netdev@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com,
jogreene@redhat.com, Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: [net-next 04/15] ixgbe: make 'action' field in struct ixgbe_fdir_filter a u64 value
Date: Mon, 25 Apr 2016 05:44:18 -0700 [thread overview]
Message-ID: <1461588269-128728-5-git-send-email-jeffrey.t.kirsher@intel.com> (raw)
In-Reply-To: <1461588269-128728-1-git-send-email-jeffrey.t.kirsher@intel.com>
From: Sridhar Samudrala <sridhar.samudrala@intel.com>
This field is used to record the RX queue index for a redirect action
passed via ring_cookie field in struct ethtool_rx_flow_spec which is
a u64 value.
For ex: after adding a filter rule to redirect to a VF using ethtool
# echo 4 > /sys/class/net/p4p1/device/sriov_numvfs
# ethtool -N p4p1 flow-type ip4 src-ip 192.168.0.1 action 0x100000000
querying for the rule shows the Action as 'Direct to queue 0'
# ethtool -n p4p1
4 RX rings available
Total 1 rules
Filter: 2045
Rule Type: Raw IPv4
Src IP addr: 192.168.0.1 mask: 0.0.0.0
Dest IP addr: 0.0.0.0 mask: 255.255.255.255
TOS: 0x0 mask: 0xff
Protocol: 0 mask: 0xff
L4 bytes: 0x0 mask: 0xffffffff
VLAN EtherType: 0x0 mask: 0xffff
VLAN: 0x0 mask: 0xffff
User-defined: 0x0 mask: 0xffffffffffffffff
Action: Direct to queue 0
With this fix, ethtool will report the right queue index even for VFs.
Action: Direct to queue 4294967296
Here 4294967296 corresponds to 0x100000000.
We need to update 'ethtool' to report the queue index as a Hex value so
that it is more user friendly and matches with the 'action' value that
is passed when adding the rule.
Signed-off-by: Sridhar Samudrala <sridhar.samudrala@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
drivers/net/ethernet/intel/ixgbe/ixgbe.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe.h b/drivers/net/ethernet/intel/ixgbe/ixgbe.h
index 61d8110..94e39c1 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe.h
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe.h
@@ -825,7 +825,7 @@ struct ixgbe_fdir_filter {
struct hlist_node fdir_node;
union ixgbe_atr_input filter;
u16 sw_idx;
- u16 action;
+ u64 action;
};
enum ixgbe_state_t {
--
2.5.5
next prev parent reply other threads:[~2016-04-25 12:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-25 12:44 [net-next 00/15][pull request] 10GbE Intel Wired LAN Driver Updates 2016-04-25 Jeff Kirsher
2016-04-25 12:44 ` [net-next 01/15] ixgbe: consolidate the configuration of spoof checking Jeff Kirsher
2016-04-25 12:44 ` [net-next 02/15] ixgbe: set VLAN spoof checking unconditionally Jeff Kirsher
2016-04-25 12:44 ` [net-next 03/15] ixgbe: fix default mac->ops.setup_link for X550EM Jeff Kirsher
2016-04-25 12:44 ` Jeff Kirsher [this message]
2016-04-25 12:44 ` [net-next 05/15] ixgbe: Add register wait for slow links Jeff Kirsher
2016-04-25 12:44 ` [net-next 06/15] ixgbevf: refactor ethtool stats handling Jeff Kirsher
2016-04-25 12:44 ` [net-next 07/15] ixgbevf: add support for per-queue ethtool stats Jeff Kirsher
2016-04-25 12:44 ` [net-next 08/15] ixgbe: Use correct FC setup function for x550em_a Jeff Kirsher
2016-04-25 12:44 ` [net-next 09/15] ixgbe: Add work around for empty SFP+ cage crosstalk Jeff Kirsher
2016-04-25 12:44 ` [net-next 10/15] ixgbe: use BIT() macro Jeff Kirsher
2016-04-25 12:44 ` [net-next 11/15] ixgbe: resolve shift of negative value warning Jeff Kirsher
2016-04-25 12:44 ` [net-next 12/15] ixgbevf: make use of BIT() macro to avoid shift of signed values Jeff Kirsher
2016-04-25 12:44 ` [net-next 13/15] ixgbe/ixgbevf: Add support for GSO partial Jeff Kirsher
2016-04-25 12:44 ` [net-next 14/15] ixgbevf: Move API negotiation function into mac_ops Jeff Kirsher
2016-04-25 12:44 ` [net-next 15/15] ixgbe: use msleep for long delays Jeff Kirsher
2016-04-25 19:12 ` [net-next 00/15][pull request] 10GbE Intel Wired LAN Driver Updates 2016-04-25 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1461588269-128728-5-git-send-email-jeffrey.t.kirsher@intel.com \
--to=jeffrey.t.kirsher@intel.com \
--cc=davem@davemloft.net \
--cc=jogreene@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@redhat.com \
--cc=sassmann@redhat.com \
--cc=sridhar.samudrala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).