From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, sd@queasysnail.net,
johannes@sipsolutions.net, kvalo@codeaurora.org,
linux-wireless@vger.kernel.org, jack@suse.com,
linux-kernel@vger.kernel.org, pshelar@nicira.com,
dev@openvswitch.org, jhs@mojatatu.com,
philipp.reisner@linbit.com, lars.ellenberg@linbit.com,
drbd-dev@lists.linbit.com,
Nicolas Dichtel <nicolas.dichtel@6wind.com>
Subject: [PATCH net-next 6/8] rtnl: align nlattr properly when needed
Date: Tue, 26 Apr 2016 10:06:16 +0200 [thread overview]
Message-ID: <1461657978-13360-7-git-send-email-nicolas.dichtel@6wind.com> (raw)
In-Reply-To: <1461657978-13360-1-git-send-email-nicolas.dichtel@6wind.com>
Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
---
net/core/rtnetlink.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
index 9efc1f34ef3b..5503dfe6a050 100644
--- a/net/core/rtnetlink.c
+++ b/net/core/rtnetlink.c
@@ -876,7 +876,7 @@ static noinline size_t if_nlmsg_size(const struct net_device *dev,
+ nla_total_size(IFNAMSIZ) /* IFLA_IFNAME */
+ nla_total_size(IFALIASZ) /* IFLA_IFALIAS */
+ nla_total_size(IFNAMSIZ) /* IFLA_QDISC */
- + nla_total_size(sizeof(struct rtnl_link_ifmap))
+ + nla_total_size_64bit(sizeof(struct rtnl_link_ifmap))
+ nla_total_size(sizeof(struct rtnl_link_stats))
+ nla_total_size_64bit(sizeof(struct rtnl_link_stats64))
+ nla_total_size(MAX_ADDR_LEN) /* IFLA_ADDRESS */
@@ -1181,7 +1181,7 @@ static int rtnl_fill_link_ifmap(struct sk_buff *skb, struct net_device *dev)
.dma = dev->dma,
.port = dev->if_port,
};
- if (nla_put(skb, IFLA_MAP, sizeof(map), &map))
+ if (nla_put_64bit(skb, IFLA_MAP, sizeof(map), &map, IFLA_PAD))
return -EMSGSIZE;
return 0;
--
2.8.1
prev parent reply other threads:[~2016-04-26 8:06 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-26 8:06 [PATCH net-next 0/8] netlink: align attributes when needed (patchset #3) Nicolas Dichtel
[not found] ` <1461657978-13360-1-git-send-email-nicolas.dichtel-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2016-04-26 8:06 ` [PATCH net-next 1/8] macsec: use nla_put_u64_64bit() Nicolas Dichtel
2016-04-26 8:06 ` [PATCH net-next 2/8] drivers/wireless: " Nicolas Dichtel
2016-04-26 8:06 ` [PATCH net-next 3/8] fs/quota: " Nicolas Dichtel
[not found] ` <1461657978-13360-4-git-send-email-nicolas.dichtel-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2016-04-26 11:08 ` Jan Kara
[not found] ` <20160426110848.GD27612-4I4JzKEfoa/jFM9bn6wA6Q@public.gmane.org>
2016-04-26 12:31 ` Nicolas Dichtel
[not found] ` <571F5FBE.8050900-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2016-04-26 12:37 ` Jan Kara
2016-04-26 16:24 ` David Miller
2016-04-26 8:06 ` [PATCH net-next 4/8] sock_diag: align nlattr properly when needed Nicolas Dichtel
2016-04-26 8:06 ` [PATCH net-next 7/8] neigh: " Nicolas Dichtel
2016-04-26 8:06 ` [PATCH net-next 8/8] sched: " Nicolas Dichtel
2016-04-26 11:54 ` [PATCH net-next 0/8] netlink: align attributes when needed (patchset #3) Lars Ellenberg
[not found] ` <20160426115427.GB20950-w1SgEEioFePxa46PmUWvFg@public.gmane.org>
2016-04-26 12:18 ` Lars Ellenberg
2016-05-03 8:50 ` [PATCH net-next] block/drbd: use nla_put_u64_64bit() Nicolas Dichtel
2016-05-03 9:28 ` Nicolas Dichtel
2016-05-03 9:39 ` [PATCH net-next v2] " Nicolas Dichtel
[not found] ` <1462268358-19044-1-git-send-email-nicolas.dichtel-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2016-05-03 10:06 ` Lars Ellenberg
2016-05-03 12:07 ` Nicolas Dichtel
2016-05-03 16:05 ` David Miller
[not found] ` <20160503.120556.1317913903199470646.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2016-05-04 9:05 ` Lars Ellenberg
2016-05-04 12:49 ` Nicolas Dichtel
[not found] ` <5729EFBC.7040002-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2016-05-04 12:52 ` Lars Ellenberg
2016-05-04 14:27 ` Eric Dumazet
2016-05-04 16:50 ` David Miller
2016-05-04 17:13 ` Eric Dumazet
2016-05-04 16:47 ` David Miller
2016-05-03 16:06 ` David Miller
2016-05-09 9:40 ` [PATCH net-next v3] block/drbd: align properly u64 in nl messages Nicolas Dichtel
[not found] ` <1462786820-15519-1-git-send-email-nicolas.dichtel-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2016-05-09 13:15 ` Lars Ellenberg
[not found] ` <20160509131547.GX16459-w1SgEEioFePxa46PmUWvFg@public.gmane.org>
2016-05-10 9:09 ` Nicolas Dichtel
[not found] ` <5731A561.6090509-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2016-05-10 9:40 ` Lars Ellenberg
2016-05-10 10:06 ` [Drbd-dev] " Nicolas Dichtel
2016-05-10 15:39 ` David Miller
[not found] ` <20160510.113949.2077250222547175741.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2016-05-10 19:09 ` Lars Ellenberg
2016-05-10 19:26 ` [Drbd-dev] " David Miller
2016-04-26 16:25 ` [PATCH net-next 0/8] netlink: align attributes when needed (patchset #3) David Miller
2016-04-26 16:02 ` David Miller
2016-04-26 8:06 ` [PATCH net-next 5/8] ovs: align nlattr properly when needed Nicolas Dichtel
2016-04-26 8:06 ` Nicolas Dichtel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1461657978-13360-7-git-send-email-nicolas.dichtel@6wind.com \
--to=nicolas.dichtel@6wind.com \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=drbd-dev@lists.linbit.com \
--cc=jack@suse.com \
--cc=jhs@mojatatu.com \
--cc=johannes@sipsolutions.net \
--cc=kvalo@codeaurora.org \
--cc=lars.ellenberg@linbit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=philipp.reisner@linbit.com \
--cc=pshelar@nicira.com \
--cc=sd@queasysnail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).