public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Eric Dumazet <edumazet@google.com>
To: "David S . Miller" <davem@davemloft.net>
Cc: netdev <netdev@vger.kernel.org>,
	Eric Dumazet <edumazet@google.com>,
	Eric Dumazet <eric.dumazet@gmail.com>
Subject: [PATCH net-next 5/6] sctp: prepare for socket backlog behavior change
Date: Wed, 27 Apr 2016 22:25:51 -0700	[thread overview]
Message-ID: <1461821152-23200-6-git-send-email-edumazet@google.com> (raw)
In-Reply-To: <1461821152-23200-1-git-send-email-edumazet@google.com>

sctp_inq_push() will soon be called without BH being blocked
when generic socket code flushes the socket backlog.

It is very possible SCTP can be converted to not rely on BH,
but this needs to be done by SCTP experts.

Signed-off-by: Eric Dumazet <edumazet@google.com>
---
 net/sctp/inqueue.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/net/sctp/inqueue.c b/net/sctp/inqueue.c
index b335ffcef0b9..9d87bba0ff1d 100644
--- a/net/sctp/inqueue.c
+++ b/net/sctp/inqueue.c
@@ -89,10 +89,12 @@ void sctp_inq_push(struct sctp_inq *q, struct sctp_chunk *chunk)
 	 * Eventually, we should clean up inqueue to not rely
 	 * on the BH related data structures.
 	 */
+	local_bh_disable();
 	list_add_tail(&chunk->list, &q->in_chunk_list);
 	if (chunk->asoc)
 		chunk->asoc->stats.ipackets++;
 	q->immediate.func(&q->immediate);
+	local_bh_enable();
 }
 
 /* Peek at the next chunk on the inqeue. */
-- 
2.8.0.rc3.226.g39d4020

  parent reply	other threads:[~2016-04-28  5:26 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-28  5:25 [PATCH net-next 0/6] net: make TCP preemptible Eric Dumazet
2016-04-28  5:25 ` [PATCH net-next 1/6] tcp: do not assume TCP code is non preemptible Eric Dumazet
2016-04-29  1:08   ` Eric Dumazet
2016-04-28  5:25 ` [PATCH net-next 2/6] tcp: do not block bh during prequeue processing Eric Dumazet
2016-04-28  5:25 ` [PATCH net-next 3/6] dccp: do not assume DCCP code is non preemptible Eric Dumazet
2016-04-28  5:25 ` [PATCH net-next 4/6] udp: prepare for non BH masking at backlog processing Eric Dumazet
2016-04-28  5:25 ` Eric Dumazet [this message]
2016-04-28  5:25 ` [PATCH net-next 6/6] net: do not block BH while processing socket backlog Eric Dumazet
2016-04-28 17:23 ` [PATCH net-next 0/6] net: make TCP preemptible Alexei Starovoitov
2016-04-28 17:41   ` Eric Dumazet
2016-04-28 17:51     ` Alexei Starovoitov
2016-04-28 18:04       ` Eric Dumazet
2016-04-28 21:18 ` Marcelo Ricardo Leitner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1461821152-23200-6-git-send-email-edumazet@google.com \
    --to=edumazet@google.com \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox