From: Hannes Frederic Sowa <hannes@stressinduktion.org>
To: Jiri Pirko <jiri@resnulli.us>, netdev@vger.kernel.org
Cc: davem@davemloft.net, idosch@mellanox.com, eladr@mellanox.com,
yotamg@mellanox.com, dsa@cumulusnetworks.com,
shm@cumulusnetworks.com
Subject: Re: [patch net-next] vrf: add exit function and allow module unload
Date: Wed, 04 May 2016 12:23:42 +0200 [thread overview]
Message-ID: <1462357422.1666076.597731009.4C5E1305@webmail.messagingengine.com> (raw)
In-Reply-To: <1462357236-6297-1-git-send-email-jiri@resnulli.us>
Hello Jiri,
On Wed, May 4, 2016, at 12:20, Jiri Pirko wrote:
> drivers/net/vrf.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/net/vrf.c b/drivers/net/vrf.c
> index 8a8f1e5..b217c2d 100644
> --- a/drivers/net/vrf.c
> +++ b/drivers/net/vrf.c
> @@ -839,7 +839,14 @@ error:
> return rc;
> }
>
> +static void __exit vrf_exit_module(void)
> +{
> + rtnl_link_unregister(&vrf_link_ops);
> + unregister_netdevice_notifier(&vrf_notifier_block);
> +}
> +
> module_init(vrf_init_module);
> +module_exit(vrf_exit_module);
The dst_entries created by vrf don't carry a reference to THIS_MODULE
but have a code dependency to the vrf module (e.g. via
vrf_output/vrf_output6) that gets published. This is exactly the same
why ipv6 cannot be unloaded.
Bye,
Hannes
next prev parent reply other threads:[~2016-05-04 10:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-04 10:20 [patch net-next] vrf: add exit function and allow module unload Jiri Pirko
2016-05-04 10:23 ` Hannes Frederic Sowa [this message]
2016-05-04 10:24 ` Jiri Pirko
2016-05-04 15:59 ` David Miller
2016-05-04 16:05 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1462357422.1666076.597731009.4C5E1305@webmail.messagingengine.com \
--to=hannes@stressinduktion.org \
--cc=davem@davemloft.net \
--cc=dsa@cumulusnetworks.com \
--cc=eladr@mellanox.com \
--cc=idosch@mellanox.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=shm@cumulusnetworks.com \
--cc=yotamg@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox