From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Crispin Subject: [PATCH 09/12] net-next: mediatek: increase watchdog_timeo Date: Thu, 5 May 2016 11:26:22 +0200 Message-ID: <1462440385-51939-10-git-send-email-john@phrozen.org> References: <1462440385-51939-1-git-send-email-john@phrozen.org> Cc: nbd@nbd.name, netdev@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, John Crispin To: "David S. Miller" Return-path: In-Reply-To: <1462440385-51939-1-git-send-email-john@phrozen.org> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org During stress testing, after reducing the threshold value, we have seen TX timeouts that were caused by the watchdog_timeo value being too low. Increase the value to 5 * HZ which is a value commonly used by many other drivers. Signed-off-by: John Crispin --- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c index 4439991..12e9f1a 100644 --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c @@ -1704,7 +1704,7 @@ static int mtk_add_mac(struct mtk_eth *eth, struct device_node *np) mac->hw_stats->reg_offset = id * MTK_STAT_OFFSET; SET_NETDEV_DEV(eth->netdev[id], eth->dev); - eth->netdev[id]->watchdog_timeo = HZ; + eth->netdev[id]->watchdog_timeo = 5 * HZ; eth->netdev[id]->netdev_ops = &mtk_netdev_ops; eth->netdev[id]->base_addr = (unsigned long)eth->base; eth->netdev[id]->vlan_features = MTK_HW_FEATURES & -- 1.7.10.4