From: John Crispin <john-Pj+rj9U5foFAfugRpC6u6w@public.gmane.org>
To: "David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
John Crispin <john-Pj+rj9U5foFAfugRpC6u6w@public.gmane.org>,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
nbd-Vt+b4OUoWG0@public.gmane.org
Subject: [PATCH 05/12] net-next: mediatek: dropped rx packets are not being counted properly
Date: Thu, 5 May 2016 11:26:18 +0200 [thread overview]
Message-ID: <1462440385-51939-6-git-send-email-john@phrozen.org> (raw)
In-Reply-To: <1462440385-51939-1-git-send-email-john-Pj+rj9U5foFAfugRpC6u6w@public.gmane.org>
There are 2 places inside mtk_poll_rx where rx_dropped is not being
incremented properly. Fix this by adding the missing code to increment
the counter.
Signed-off-by: John Crispin <john-Pj+rj9U5foFAfugRpC6u6w@public.gmane.org>
---
drivers/net/ethernet/mediatek/mtk_eth_soc.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
index 7fdd1a3..2e79af9 100644
--- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
+++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
@@ -826,6 +826,7 @@ static int mtk_poll_rx(struct napi_struct *napi, int budget,
DMA_FROM_DEVICE);
if (unlikely(dma_mapping_error(&netdev->dev, dma_addr))) {
skb_free_frag(new_data);
+ netdev->stats.rx_dropped++;
goto release_desc;
}
@@ -833,6 +834,7 @@ static int mtk_poll_rx(struct napi_struct *napi, int budget,
skb = build_skb(data, ring->frag_size);
if (unlikely(!skb)) {
put_page(virt_to_head_page(new_data));
+ netdev->stats.rx_dropped++;
goto release_desc;
}
skb_reserve(skb, NET_SKB_PAD + NET_IP_ALIGN);
--
1.7.10.4
next prev parent reply other threads:[~2016-05-05 9:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-05 9:26 [PATCH 00/12] net-next: mediatek: bug fixes and tx stall fixes John Crispin
2016-05-05 9:26 ` [PATCH 01/12] net-next: mediatek: fix DQL support John Crispin
[not found] ` <1462440385-51939-1-git-send-email-john-Pj+rj9U5foFAfugRpC6u6w@public.gmane.org>
2016-05-05 9:26 ` [PATCH 02/12] net-next: mediatek: add missing return code check John Crispin
2016-05-05 9:26 ` [PATCH 03/12] net-next: mediatek: fix missing free of scratch memory John Crispin
2016-05-05 9:26 ` [PATCH 04/12] net-next: mediatek: invalid buffer lookup in mtk_tx_map() John Crispin
2016-05-05 9:26 ` John Crispin [this message]
2016-05-05 9:26 ` [PATCH 06/12] net-next: mediatek: add next data pointer coherency protection John Crispin
2016-05-05 9:26 ` [PATCH 07/12] net-next: mediatek: disable all interrupts during probe John Crispin
2016-05-05 9:26 ` [PATCH 08/12] net-next: mediatek: fix threshold value John Crispin
2016-05-05 9:26 ` [PATCH 09/12] net-next: mediatek: increase watchdog_timeo John Crispin
2016-05-05 9:26 ` [PATCH 10/12] net-next: mediatek: fix off by one in the TX ring allocation John Crispin
2016-05-05 9:26 ` [PATCH 11/12] net-next: mediatek: only wake the queue if it is stopped John Crispin
2016-05-05 9:26 ` [PATCH 12/12] net-next: mediatek: remove superfluous queue wake up call John Crispin
2016-05-05 12:25 ` [PATCH 00/12] net-next: mediatek: bug fixes and tx stall fixes Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1462440385-51939-6-git-send-email-john@phrozen.org \
--to=john-pj+rj9u5fofafugrpc6u6w@public.gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=nbd-Vt+b4OUoWG0@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).