netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: John Crispin <john@phrozen.org>
To: davem@davemloft.net
Cc: nbd@nbd.name, netdev@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	John Crispin <john@phrozen.org>
Subject: [PATCH V2 15/22] net-next: mediatek: only wake the queue if it is stopped
Date: Mon,  9 May 2016 12:04:07 +0200	[thread overview]
Message-ID: <1462788254-40572-16-git-send-email-john@phrozen.org> (raw)
In-Reply-To: <1462788254-40572-1-git-send-email-john@phrozen.org>

The current code unconditionally wakes up the queue at the end of each
tx_poll action. Change the code to only wake up the queues if any of
them have actually been stopped before.

Signed-off-by: John Crispin <john@phrozen.org>
---
 drivers/net/ethernet/mediatek/mtk_eth_soc.c |   17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
index 9f4b533..7f42178 100644
--- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
+++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
@@ -703,6 +703,20 @@ static inline int mtk_cal_txd_req(struct sk_buff *skb)
 	return nfrags;
 }
 
+static int mtk_queue_stopped(struct mtk_eth *eth)
+{
+	int i;
+
+	for (i = 0; i < MTK_MAC_COUNT; i++) {
+		if (!eth->netdev[i])
+			continue;
+		if (netif_queue_stopped(eth->netdev[i]))
+			return 1;
+	}
+
+	return 0;
+}
+
 static void mtk_wake_queue(struct mtk_eth *eth)
 {
 	int i;
@@ -947,7 +961,8 @@ static int mtk_poll_tx(struct mtk_eth *eth, int budget, bool *tx_again)
 	if (!total)
 		return 0;
 
-	if (atomic_read(&ring->free_count) > ring->thresh)
+	if (mtk_queue_stopped(eth) &&
+	    (atomic_read(&ring->free_count) > ring->thresh))
 		mtk_wake_queue(eth);
 
 	return total;
-- 
1.7.10.4

  parent reply	other threads:[~2016-05-09 10:28 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-09 10:03 [PATCH V2 00/22] net-next: mediatek: various fixes and IRQ grouping John Crispin
2016-05-09 10:03 ` [PATCH V2 01/22] net-next: mediatek: use mdiobus_free() in favour of kfree() John Crispin
2016-05-09 12:07   ` Andrew Lunn
2016-05-09 10:03 ` [PATCH V2 02/22] net-next: mediatek: fix gigabit and flow control advertisement John Crispin
2016-05-09 10:03 ` [PATCH V2 03/22] net-next: mediatek: add fixed-phy support John Crispin
2016-05-09 10:03 ` [PATCH V2 04/22] net-next: mediatek: properly handle RGMII modes John Crispin
2016-05-09 12:09   ` Andrew Lunn
2016-05-09 10:03 ` [PATCH V2 05/22] net-next: mediatek: fix DQL support John Crispin
2016-05-09 10:03 ` [PATCH V2 06/22] net-next: mediatek: add missing return code check John Crispin
2016-05-09 10:03 ` [PATCH V2 07/22] net-next: mediatek: fix missing free of scratch memory John Crispin
2016-05-09 10:04 ` [PATCH V2 08/22] net-next: mediatek: invalid buffer lookup in mtk_tx_map() John Crispin
2016-05-09 10:04 ` [PATCH V2 09/22] net-next: mediatek: dropped rx packets are not being counted properly John Crispin
2016-05-09 10:04 ` [PATCH V2 10/22] net-next: mediatek: add next data pointer coherency protection John Crispin
2016-05-09 10:04 ` [PATCH V2 11/22] net-next: mediatek: disable all interrupts during probe John Crispin
2016-05-09 10:04 ` [PATCH V2 13/22] net-next: mediatek: increase watchdog_timeo John Crispin
2016-05-09 10:04 ` John Crispin [this message]
2016-05-09 10:04 ` [PATCH V2 17/22] net-next: mediatek: remove superfluous register reads John Crispin
2016-05-09 10:04 ` [PATCH V2 19/22] net-next: mediatek: add IRQ locking John Crispin
     [not found] ` <1462788254-40572-1-git-send-email-john-Pj+rj9U5foFAfugRpC6u6w@public.gmane.org>
2016-05-09 10:04   ` [PATCH V2 12/22] net-next: mediatek: fix threshold value John Crispin
2016-05-09 10:04   ` [PATCH V2 14/22] net-next: mediatek: fix off by one in the TX ring allocation John Crispin
2016-05-09 10:04   ` [PATCH V2 16/22] net-next: mediatek: remove superfluous queue wake up call John Crispin
2016-05-09 10:04   ` [PATCH V2 18/22] net-next: mediatek: don't use intermediate variables to store IRQ masks John Crispin
2016-05-09 10:04   ` [PATCH V2 20/22] net-next: mediatek: add support for IRQ grouping John Crispin
2016-05-09 10:04 ` [PATCH V2 21/22] net-next: mediatek: change my email address John Crispin
2016-05-09 10:04 ` [PATCH V2 22/22] MAINTAINERS: " John Crispin
2016-05-09 16:02 ` [PATCH V2 00/22] net-next: mediatek: various fixes and IRQ grouping David Miller
2016-05-09 16:25   ` John Crispin
2016-05-09 16:28     ` David Miller
2016-05-09 16:34       ` John Crispin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1462788254-40572-16-git-send-email-john@phrozen.org \
    --to=john@phrozen.org \
    --cc=davem@davemloft.net \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=nbd@nbd.name \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).