From: Philippe Reynes <tremyfr@gmail.com>
To: fugang.duan@nxp.com, f.fainelli@gmail.com, davem@davemloft.net,
decot@googlers.com, ben@decadent.org.uk
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Philippe Reynes <tremyfr@gmail.com>
Subject: [PATCH v3 0/3] net: phy: add phy_ethtool_{get|set}_link_ksettings
Date: Tue, 10 May 2016 00:19:40 +0200 [thread overview]
Message-ID: <1462832383-25541-1-git-send-email-tremyfr@gmail.com> (raw)
Ethtool callbacks {get|set}_link_ksettings may be the
same for many drivers. So we add two generics callbacks
phy_ethtool_{get|set}_link_ksettings.
To use those generics callbacks, the ethernet driver must
use the pointer phydev contained in struct net_device, and
not use a private structure to store this pointer.
Changelog:
v3:
- rename function to phy_ethtool_{get|set}_link_ksettings
- move code to net/phy/phy.c
This feedback were provided by David Decotigny
v2:
- use generic function instead of macro
- ethernet driver use the pointer phydev provided by struct net_device
Those idea were provided by Ben Hutchings,
and Florian Fainelli acknowledge them.
Philippe Reynes (3):
net: phy: add phy_ethtool_{get|set}_link_ksettings
net: ethernet: fec: use phydev from struct net_device
net: ethernet: fec: use phy_ethtool_{get|set}_link_ksettings
drivers/net/ethernet/freescale/fec.h | 1 -
drivers/net/ethernet/freescale/fec_main.c | 71 +++++++++--------------------
drivers/net/phy/phy.c | 24 ++++++++++
include/linux/phy.h | 4 ++
4 files changed, 49 insertions(+), 51 deletions(-)
--
1.7.4.4
next reply other threads:[~2016-05-09 22:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-09 22:19 Philippe Reynes [this message]
2016-05-09 22:19 ` [PATCH v3 1/3] net: phy: add phy_ethtool_{get|set}_link_ksettings Philippe Reynes
2016-05-09 23:01 ` David Decotigny
2016-05-09 22:19 ` [PATCH v3 2/3] net: ethernet: fec: use phydev from struct net_device Philippe Reynes
2016-05-09 22:19 ` [PATCH v3 3/3] net: ethernet: fec: use phy_ethtool_{get|set}_link_ksettings Philippe Reynes
2016-05-10 19:06 ` [PATCH v3 0/3] net: phy: add phy_ethtool_{get|set}_link_ksettings David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1462832383-25541-1-git-send-email-tremyfr@gmail.com \
--to=tremyfr@gmail.com \
--cc=ben@decadent.org.uk \
--cc=davem@davemloft.net \
--cc=decot@googlers.com \
--cc=f.fainelli@gmail.com \
--cc=fugang.duan@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).