netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v3 0/3] net: phy: add phy_ethtool_{get|set}_link_ksettings
@ 2016-05-09 22:19 Philippe Reynes
  2016-05-09 22:19 ` [PATCH v3 1/3] " Philippe Reynes
                   ` (3 more replies)
  0 siblings, 4 replies; 6+ messages in thread
From: Philippe Reynes @ 2016-05-09 22:19 UTC (permalink / raw)
  To: fugang.duan, f.fainelli, davem, decot, ben
  Cc: netdev, linux-kernel, Philippe Reynes

Ethtool callbacks {get|set}_link_ksettings may be the
same for many drivers. So we add two generics callbacks
phy_ethtool_{get|set}_link_ksettings.

To use those generics callbacks, the ethernet driver must
use the pointer phydev contained in struct net_device, and
not use a private structure to store this pointer.

Changelog:
v3:
- rename function to phy_ethtool_{get|set}_link_ksettings
- move code to net/phy/phy.c
  This feedback were provided by David Decotigny
v2:
- use generic function instead of macro
- ethernet driver use the pointer phydev provided by struct net_device
  Those idea were provided by Ben Hutchings,
  and Florian Fainelli acknowledge them.

Philippe Reynes (3):
  net: phy: add phy_ethtool_{get|set}_link_ksettings
  net: ethernet: fec: use phydev from struct net_device
  net: ethernet: fec: use phy_ethtool_{get|set}_link_ksettings

 drivers/net/ethernet/freescale/fec.h      |    1 -
 drivers/net/ethernet/freescale/fec_main.c |   71 +++++++++--------------------
 drivers/net/phy/phy.c                     |   24 ++++++++++
 include/linux/phy.h                       |    4 ++
 4 files changed, 49 insertions(+), 51 deletions(-)

-- 
1.7.4.4

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2016-05-10 19:06 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-09 22:19 [PATCH v3 0/3] net: phy: add phy_ethtool_{get|set}_link_ksettings Philippe Reynes
2016-05-09 22:19 ` [PATCH v3 1/3] " Philippe Reynes
2016-05-09 23:01   ` David Decotigny
2016-05-09 22:19 ` [PATCH v3 2/3] net: ethernet: fec: use phydev from struct net_device Philippe Reynes
2016-05-09 22:19 ` [PATCH v3 3/3] net: ethernet: fec: use phy_ethtool_{get|set}_link_ksettings Philippe Reynes
2016-05-10 19:06 ` [PATCH v3 0/3] net: phy: add phy_ethtool_{get|set}_link_ksettings David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).