* [PATCH net-next] gtp: reload GTPv1 header after pskb_may_pull()
@ 2016-05-10 19:33 Pablo Neira Ayuso
2016-05-10 19:57 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Pablo Neira Ayuso @ 2016-05-10 19:33 UTC (permalink / raw)
To: netdev; +Cc: davem, eric.dumazet
The GTPv1 header flags indicate the presence of optional extensions
after this header. Refresh the pointer to the GTPv1 header as skb->head
might have be reallocated via pskb_may_pull().
Fixes: 459aa660eb1d ("gtp: add initial driver for datapath of GPRS Tunneling Protocol (GTP-U)")
Reported-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---
drivers/net/gtp.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c
index 8ce1104..f7caf1e 100644
--- a/drivers/net/gtp.c
+++ b/drivers/net/gtp.c
@@ -253,6 +253,8 @@ static int gtp1u_udp_encap_recv(struct gtp_dev *gtp, struct sk_buff *skb,
if (!pskb_may_pull(skb, hdrlen))
return -1;
+ gtp1 = (struct gtp1_header *)(skb->data + sizeof(struct udphdr));
+
rcu_read_lock();
pctx = gtp1_pdp_find(gtp, ntohl(gtp1->tid));
if (!pctx) {
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH net-next] gtp: reload GTPv1 header after pskb_may_pull()
2016-05-10 19:33 [PATCH net-next] gtp: reload GTPv1 header after pskb_may_pull() Pablo Neira Ayuso
@ 2016-05-10 19:57 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2016-05-10 19:57 UTC (permalink / raw)
To: pablo; +Cc: netdev, eric.dumazet
From: Pablo Neira Ayuso <pablo@netfilter.org>
Date: Tue, 10 May 2016 21:33:38 +0200
> The GTPv1 header flags indicate the presence of optional extensions
> after this header. Refresh the pointer to the GTPv1 header as skb->head
> might have be reallocated via pskb_may_pull().
>
> Fixes: 459aa660eb1d ("gtp: add initial driver for datapath of GPRS Tunneling Protocol (GTP-U)")
> Reported-by: Eric Dumazet <eric.dumazet@gmail.com>
> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-05-10 19:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-10 19:33 [PATCH net-next] gtp: reload GTPv1 header after pskb_may_pull() Pablo Neira Ayuso
2016-05-10 19:57 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).