From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rik van Riel Subject: Re: [RFC PATCH 0/2] net: threadable napi poll loop Date: Wed, 11 May 2016 11:01:43 -0400 Message-ID: <1462978903.7134.33.camel@redhat.com> References: <1462890590.23934.68.camel@edumazet-glaptop3.roam.corp.google.com> <90f3db8c-c30c-b204-576a-454939ac93ce@stressinduktion.org> <94f323a9-515e-4d75-cac8-ef0214f0499e@stressinduktion.org> <1462920697.23934.113.camel@edumazet-glaptop3.roam.corp.google.com> <20160511065527.GD3193@twins.programming.kicks-ass.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-K1dzotOHwZKWWrZDA9mi" Cc: Peter Zijlstra , Eric Dumazet , Paolo Abeni , netdev , "David S. Miller" , Jiri Pirko , Daniel Borkmann , Alexei Starovoitov , Alexander Duyck , Tom Herbert , Ingo Molnar , LKML To: Eric Dumazet , Hannes Frederic Sowa Return-path: Received: from mx1.redhat.com ([209.132.183.28]:53935 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751561AbcEKPBw (ORCPT ); Wed, 11 May 2016 11:01:52 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: --=-K1dzotOHwZKWWrZDA9mi Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2016-05-11 at 07:40 -0700, Eric Dumazet wrote: > On Wed, May 11, 2016 at 6:13 AM, Hannes Frederic Sowa > wrote: >=20 > > This looks racy to me as the ksoftirqd could be in the progress to > > stop > > and we would miss another softirq invocation. >=20 > Looking at smpboot_thread_fn(), it looks fine : >=20 Additionally, we are talking about waking up ksoftirqd on the same CPU. That means the wakeup code could interrupt ksoftirqd almost going to sleep, but the two code paths could not run simultaneously. That does narrow the scope considerably. --=20 All rights reversed --=-K1dzotOHwZKWWrZDA9mi Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAABAgAGBQJXM0lYAAoJEM553pKExN6DPN4H/2gAdBT/mc1BHccTWPl4a3JK FIKxo1oJz356WcQZnFEJeDTZlPxbe7RxT/tzQzzbpLi8yDTfTea+9cLwWSIa1g+Y pEaUhCzpPCiGZnNRnKUwp3Mr5qt9WclXWBO5JglKE65L6v6piBd8uesZOP6SGYIf EOGg1Aswriu1HQmtkGV3q0ZskHnJVnmf8w2M8S5BqBDOQi+B3oHxALCCECHBMT8V 9Ne/9dG24CobbmNnsJeDhLyst0LEWroIo6PqokoQOuQ+/Rr/rj+MckbEAcgjKYn6 z0rOgtfjcQEV6aGsoGZweFSeYeyzNkBnCV59C6YPWNQRHQL6ie0/4C2t7MdNeLk= =dNXz -----END PGP SIGNATURE----- --=-K1dzotOHwZKWWrZDA9mi--