netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Martin Willi <martin@strongswan.org>
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v2 0/2] wireless: Allow wiphy/hwsim management from user namespaces
Date: Thu, 12 May 2016 11:27:01 +0200	[thread overview]
Message-ID: <1463045221.13313.16.camel@sipsolutions.net> (raw)
In-Reply-To: <1462811639-29906-1-git-send-email-martin@strongswan.org>

Hi Martin,

Thanks for the update.

I've applied your patch now, but I think we need to do some work around
the wmediumd abstraction.

Right now, you allowed HWSIM_CMD_REGISTER only from init_net, which is
mostly fine.

However, it means that a wmediumd running in init_net will see frames
from the radios that are generated by other namespace, but will have no
way to access anything else about them, neither through hwsim netlink
nor through nl80211 or sysfs.

So I think you should change the "wmediumd_portid" variable to live
in struct hwsim_net and then allow HWSIM_CMD_REGISTER to be done inside
the net namespace.

With that, and making the other few wmediumd related operations
namespace aware, we would be able to run wmediumd in any net namespace
and have it manage all the radios created in that namespace.

johannes

  parent reply	other threads:[~2016-05-12  9:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-09 16:33 [PATCH v2 0/2] wireless: Allow wiphy/hwsim management from user namespaces Martin Willi
     [not found] ` <1462811639-29906-1-git-send-email-martin-jzJueiEJWxp8fCCB1iTX4w@public.gmane.org>
2016-05-09 16:33   ` [PATCH v2 1/2] nl80211: Allow privileged operations " Martin Willi
2016-05-09 16:33   ` [PATCH v2 2/2] mac80211_hwsim: Allow managing radios from non-initial namespaces Martin Willi
2016-05-12  9:27 ` Johannes Berg [this message]
2016-05-13 10:37   ` [PATCH v2 0/2] wireless: Allow wiphy/hwsim management from user namespaces Martin Willi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1463045221.13313.16.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=martin@strongswan.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).