From: Amir Vadai <amir@vadai.me>
To: "David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org, Or Gerlitz <ogerlitz@mellanox.com>,
Amir Vadai <amir@vadai.me>, Saeed Mahameed <saeedm@mellanox.com>,
Amir Vadai <amirva@mellanox.com>
Subject: [PATCH net-next 3/8] net/sched: cls_flower: Hardware offloaded filters statistics support
Date: Fri, 13 May 2016 12:55:37 +0000 [thread overview]
Message-ID: <1463144142-13810-4-git-send-email-amir@vadai.me> (raw)
In-Reply-To: <1463144142-13810-1-git-send-email-amir@vadai.me>
From: Amir Vadai <amirva@mellanox.com>
Introduce a new command in ndo_setup_tc() for hardware offloaded
filters, to call the NIC driver, and make it update the statistics.
This will be done before dumping the filter and its statistics.
Signed-off-by: Amir Vadai <amirva@mellanox.com>
---
include/net/pkt_cls.h | 1 +
net/sched/cls_flower.c | 21 +++++++++++++++++++++
2 files changed, 22 insertions(+)
diff --git a/include/net/pkt_cls.h b/include/net/pkt_cls.h
index caa5e18..cc561a8 100644
--- a/include/net/pkt_cls.h
+++ b/include/net/pkt_cls.h
@@ -412,6 +412,7 @@ static inline bool tc_should_offload(struct net_device *dev, u32 flags)
enum tc_fl_command {
TC_CLSFLOWER_REPLACE,
TC_CLSFLOWER_DESTROY,
+ TC_CLSFLOWER_STATS,
};
struct tc_cls_flower_offload {
diff --git a/net/sched/cls_flower.c b/net/sched/cls_flower.c
index 2181ffc..730aaca 100644
--- a/net/sched/cls_flower.c
+++ b/net/sched/cls_flower.c
@@ -210,6 +210,25 @@ static void fl_hw_replace_filter(struct tcf_proto *tp,
dev->netdev_ops->ndo_setup_tc(dev, tp->q->handle, tp->protocol, &tc);
}
+static void fl_hw_update_stats(struct tcf_proto *tp, struct cls_fl_filter *f)
+{
+ struct net_device *dev = tp->q->dev_queue->dev;
+ struct tc_cls_flower_offload offload = {0};
+ struct tc_to_netdev tc;
+
+ if (!tc_should_offload(dev, 0))
+ return;
+
+ offload.command = TC_CLSFLOWER_STATS;
+ offload.cookie = (unsigned long)f;
+ offload.exts = &f->exts;
+
+ tc.type = TC_SETUP_CLSFLOWER;
+ tc.cls_flower = &offload;
+
+ dev->netdev_ops->ndo_setup_tc(dev, tp->q->handle, tp->protocol, &tc);
+}
+
static bool fl_destroy(struct tcf_proto *tp, bool force)
{
struct cls_fl_head *head = rtnl_dereference(tp->root);
@@ -662,6 +681,8 @@ static int fl_dump(struct net *net, struct tcf_proto *tp, unsigned long fh,
goto nla_put_failure;
}
+ fl_hw_update_stats(tp, f);
+
if (fl_dump_key_val(skb, key->eth.dst, TCA_FLOWER_KEY_ETH_DST,
mask->eth.dst, TCA_FLOWER_KEY_ETH_DST_MASK,
sizeof(key->eth.dst)) ||
--
2.8.0
next prev parent reply other threads:[~2016-05-13 12:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-13 12:55 [PATCH net-next 0/8] sched,mlx5: Offloaded TC flower filter statistics Amir Vadai
2016-05-13 12:55 ` [PATCH net-next 1/8] net/sched: Enable netdev drivers to update statistics of offloaded actions Amir Vadai
2016-05-13 12:55 ` [PATCH net-next 2/8] net/sched: act_gact: Update statistics when offloaded to hardware Amir Vadai
2016-05-13 12:55 ` Amir Vadai [this message]
2016-05-13 12:55 ` [PATCH net-next 4/8] net/mlx5_core: Use a macro in mlx5_command_str() Amir Vadai
2016-05-13 12:55 ` [PATCH net-next 5/8] net/mlx5_core: Firmware commands to support flow counters Amir Vadai
2016-05-13 12:55 ` [PATCH net-next 6/8] net/mlx5_core: Introduce flow steering destination of type counter Amir Vadai
2016-05-13 12:55 ` [PATCH net-next 7/8] net/mlx5_core: Flow counters infrastructure Amir Vadai
2016-05-13 12:55 ` [PATCH net-next 8/8] net/mlx5e: Hardware offloaded flower filter statistics support Amir Vadai
2016-05-16 17:44 ` [PATCH net-next 0/8] sched,mlx5: Offloaded TC flower filter statistics David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1463144142-13810-4-git-send-email-amir@vadai.me \
--to=amir@vadai.me \
--cc=amirva@mellanox.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=saeedm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).