* [PATCH] ptp: use memdup_user().
@ 2016-05-20 12:21 Muhammad Falak R Wani
2016-05-20 12:54 ` Richard Cochran
2016-05-23 21:05 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Muhammad Falak R Wani @ 2016-05-20 12:21 UTC (permalink / raw)
To: Richard Cochran; +Cc: open list:PTP HARDWARE CLOCK SUPPORT, open list
Use memdup_user to duplicate a memory region from user-space to
kernel-space, instead of open coding using kmalloc & copy_from_user.
Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
---
drivers/ptp/ptp_chardev.c | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/ptp/ptp_chardev.c b/drivers/ptp/ptp_chardev.c
index 579fd65..0b1ac6b 100644
--- a/drivers/ptp/ptp_chardev.c
+++ b/drivers/ptp/ptp_chardev.c
@@ -208,14 +208,9 @@ long ptp_ioctl(struct posix_clock *pc, unsigned int cmd, unsigned long arg)
break;
case PTP_SYS_OFFSET:
- sysoff = kmalloc(sizeof(*sysoff), GFP_KERNEL);
- if (!sysoff) {
- err = -ENOMEM;
- break;
- }
- if (copy_from_user(sysoff, (void __user *)arg,
- sizeof(*sysoff))) {
- err = -EFAULT;
+ sysoff = memdup_user((void __user *)arg, sizeof(*sysoff));
+ if (IS_ERR(sysoff)) {
+ err = PTR_ERR(sysoff);
break;
}
if (sysoff->n_samples > PTP_MAX_SAMPLES) {
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ptp: use memdup_user().
2016-05-20 12:21 [PATCH] ptp: use memdup_user() Muhammad Falak R Wani
@ 2016-05-20 12:54 ` Richard Cochran
2016-05-23 21:05 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Richard Cochran @ 2016-05-20 12:54 UTC (permalink / raw)
To: Muhammad Falak R Wani; +Cc: open list:PTP HARDWARE CLOCK SUPPORT, open list
On Fri, May 20, 2016 at 05:51:02PM +0530, Muhammad Falak R Wani wrote:
> Use memdup_user to duplicate a memory region from user-space to
> kernel-space, instead of open coding using kmalloc & copy_from_user.
>
> Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
Acked-by: Richard Cochran <richardcochran@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ptp: use memdup_user().
2016-05-20 12:21 [PATCH] ptp: use memdup_user() Muhammad Falak R Wani
2016-05-20 12:54 ` Richard Cochran
@ 2016-05-23 21:05 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2016-05-23 21:05 UTC (permalink / raw)
To: falakreyaz; +Cc: richardcochran, netdev, linux-kernel
From: Muhammad Falak R Wani <falakreyaz@gmail.com>
Date: Fri, 20 May 2016 17:51:02 +0530
> Use memdup_user to duplicate a memory region from user-space to
> kernel-space, instead of open coding using kmalloc & copy_from_user.
>
> Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-05-23 21:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-20 12:21 [PATCH] ptp: use memdup_user() Muhammad Falak R Wani
2016-05-20 12:54 ` Richard Cochran
2016-05-23 21:05 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).