* [PATCH] brcmfmac: print error in p2p_ifadd firmware command fails @ 2016-05-24 21:01 Rafał Miłecki 2016-05-24 21:05 ` [PATCH V2] brcmfmac: print error if " Rafał Miłecki 0 siblings, 1 reply; 6+ messages in thread From: Rafał Miłecki @ 2016-05-24 21:01 UTC (permalink / raw) To: Kalle Valo Cc: Rafał Miłecki, Brett Rudley, Arend van Spriel, Franky (Zhenhui) Lin, Hante Meuleman, Pieter-Paul Giesberts, open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER, open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER, open list:NETWORKING DRIVERS, open list This is helpful for debugging, without this all I was getting from "iw" command on device with BCM43602 was: > command failed: Too many open files in system (-23) Signed-off-by: Rafał Miłecki <zajec5@gmail.com> --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c index 1652a48..f7b7e29 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c @@ -2031,7 +2031,7 @@ static int brcmf_p2p_request_p2p_if(struct brcmf_p2p_info *p2p, err = brcmf_fil_iovar_data_set(ifp, "p2p_ifadd", &if_request, sizeof(if_request)); if (err) - return err; + brcmf_err("p2p_ifadd failed %d\n", err); return err; } -- 1.8.4.5 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH V2] brcmfmac: print error if p2p_ifadd firmware command fails 2016-05-24 21:01 [PATCH] brcmfmac: print error in p2p_ifadd firmware command fails Rafał Miłecki @ 2016-05-24 21:05 ` Rafał Miłecki 2016-05-25 21:05 ` Arend van Spriel 2016-05-25 22:44 ` [PATCH V3] " Rafał Miłecki 0 siblings, 2 replies; 6+ messages in thread From: Rafał Miłecki @ 2016-05-24 21:05 UTC (permalink / raw) To: Kalle Valo Cc: Rafał Miłecki, Brett Rudley, Arend van Spriel, Franky (Zhenhui) Lin, Hante Meuleman, Pieter-Paul Giesberts, open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER, open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER, open list:NETWORKING DRIVERS, open list This is helpful for debugging, without this all I was getting from "iw" command on device with BCM43602 was: > command failed: Too many open files in system (-23) Signed-off-by: Rafał Miłecki <zajec5@gmail.com> --- V2: s/in/if/ in commit message --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c index 1652a48..f7b7e29 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c @@ -2031,7 +2031,7 @@ static int brcmf_p2p_request_p2p_if(struct brcmf_p2p_info *p2p, err = brcmf_fil_iovar_data_set(ifp, "p2p_ifadd", &if_request, sizeof(if_request)); if (err) - return err; + brcmf_err("p2p_ifadd failed %d\n", err); return err; } -- 1.8.4.5 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH V2] brcmfmac: print error if p2p_ifadd firmware command fails 2016-05-24 21:05 ` [PATCH V2] brcmfmac: print error if " Rafał Miłecki @ 2016-05-25 21:05 ` Arend van Spriel 2016-05-25 22:44 ` [PATCH V3] " Rafał Miłecki 1 sibling, 0 replies; 6+ messages in thread From: Arend van Spriel @ 2016-05-25 21:05 UTC (permalink / raw) To: Rafał Miłecki, Kalle Valo Cc: Brett Rudley, Arend van Spriel, Franky (Zhenhui) Lin, Hante Meuleman, Pieter-Paul Giesberts, open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER, open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER, open list:NETWORKING DRIVERS, open list On 24-05-16 23:05, Rafał Miłecki wrote: > This is helpful for debugging, without this all I was getting from "iw" > command on device with BCM43602 was: >> command failed: Too many open files in system (-23) > > Signed-off-by: Rafał Miłecki <zajec5@gmail.com> > --- > V2: s/in/if/ in commit message > --- > drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c > index 1652a48..f7b7e29 100644 > --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c > +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c > @@ -2031,7 +2031,7 @@ static int brcmf_p2p_request_p2p_if(struct brcmf_p2p_info *p2p, > err = brcmf_fil_iovar_data_set(ifp, "p2p_ifadd", &if_request, > sizeof(if_request)); > if (err) > - return err; > + brcmf_err("p2p_ifadd failed %d\n", err); I would prefer adding a more generic failure message including ifname and type in brcmf_cfg80211_add_iface() in cfg80211.c. Regards, Arend > > return err; > } > ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH V3] brcmfmac: print error if p2p_ifadd firmware command fails 2016-05-24 21:05 ` [PATCH V2] brcmfmac: print error if " Rafał Miłecki 2016-05-25 21:05 ` Arend van Spriel @ 2016-05-25 22:44 ` Rafał Miłecki 2016-05-26 8:07 ` Arend Van Spriel 2016-05-26 23:03 ` [PATCH V4] brcmfmac: print errors if creating interface fails Rafał Miłecki 1 sibling, 2 replies; 6+ messages in thread From: Rafał Miłecki @ 2016-05-25 22:44 UTC (permalink / raw) To: Kalle Valo Cc: Rafał Miłecki, Brett Rudley, Arend van Spriel, Franky (Zhenhui) Lin, Hante Meuleman, Pieter-Paul Giesberts, open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER, open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER, open list:NETWORKING DRIVERS, open list This is helpful for debugging, without this all I was getting from "iw" command on device with BCM43602 was: > command failed: Too many open files in system (-23) Signed-off-by: Rafał Miłecki <zajec5@gmail.com> --- V2: s/in/if/ in commit message V3: Add one more error message as suggested by Arend --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c index 1652a48..bc26aec 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c @@ -2031,7 +2031,7 @@ static int brcmf_p2p_request_p2p_if(struct brcmf_p2p_info *p2p, err = brcmf_fil_iovar_data_set(ifp, "p2p_ifadd", &if_request, sizeof(if_request)); if (err) - return err; + brcmf_err("p2p_ifadd failed %d\n", err); return err; } @@ -2185,6 +2185,7 @@ struct wireless_dev *brcmf_p2p_add_vif(struct wiphy *wiphy, const char *name, err = brcmf_p2p_request_p2p_if(&cfg->p2p, ifp, cfg->p2p.int_addr, iftype); if (err) { + brcmf_err("Failed to request P2P virtual interface %s\n", name); brcmf_cfg80211_arm_vif_event(cfg, NULL); goto fail; } -- 1.8.4.5 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH V3] brcmfmac: print error if p2p_ifadd firmware command fails 2016-05-25 22:44 ` [PATCH V3] " Rafał Miłecki @ 2016-05-26 8:07 ` Arend Van Spriel 2016-05-26 23:03 ` [PATCH V4] brcmfmac: print errors if creating interface fails Rafał Miłecki 1 sibling, 0 replies; 6+ messages in thread From: Arend Van Spriel @ 2016-05-26 8:07 UTC (permalink / raw) To: Rafał Miłecki, Kalle Valo Cc: Brett Rudley, Arend van Spriel, Franky (Zhenhui) Lin, Hante Meuleman, Pieter-Paul Giesberts, open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER, open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER, open list:NETWORKING DRIVERS, open list On 26-5-2016 0:44, Rafał Miłecki wrote: > This is helpful for debugging, without this all I was getting from "iw" > command on device with BCM43602 was: >> command failed: Too many open files in system (-23) > > Signed-off-by: Rafał Miłecki <zajec5@gmail.com> > --- > V2: s/in/if/ in commit message > V3: Add one more error message as suggested by Arend > --- > drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c > index 1652a48..bc26aec 100644 > --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c > +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c > @@ -2031,7 +2031,7 @@ static int brcmf_p2p_request_p2p_if(struct brcmf_p2p_info *p2p, > err = brcmf_fil_iovar_data_set(ifp, "p2p_ifadd", &if_request, > sizeof(if_request)); > if (err) > - return err; > + brcmf_err("p2p_ifadd failed %d\n", err); > > return err; > } > @@ -2185,6 +2185,7 @@ struct wireless_dev *brcmf_p2p_add_vif(struct wiphy *wiphy, const char *name, > err = brcmf_p2p_request_p2p_if(&cfg->p2p, ifp, cfg->p2p.int_addr, > iftype); > if (err) { > + brcmf_err("Failed to request P2P virtual interface %s\n", name); > brcmf_cfg80211_arm_vif_event(cfg, NULL); > goto fail; > } Not exactly what I meant. I meant instead of and the function I would like the error message in is brcmf_cfg80211_add_iface() so you also get an error message when AP interface creation fails. Regards, Arend ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH V4] brcmfmac: print errors if creating interface fails 2016-05-25 22:44 ` [PATCH V3] " Rafał Miłecki 2016-05-26 8:07 ` Arend Van Spriel @ 2016-05-26 23:03 ` Rafał Miłecki 1 sibling, 0 replies; 6+ messages in thread From: Rafał Miłecki @ 2016-05-26 23:03 UTC (permalink / raw) To: Kalle Valo Cc: Rafał Miłecki, Brett Rudley, Arend van Spriel, Franky (Zhenhui) Lin, Hante Meuleman, Pieter-Paul Giesberts, open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER, open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER, open list:NETWORKING DRIVERS, open list This is helpful for debugging. Without this all I was getting from "iw" command on failed creating of P2P interface was: > command failed: Too many open files in system (-23) Signed-off-by: Rafał Miłecki <zajec5@gmail.com> --- V2: s/in/if/ in commit message V3: Add one more error message as suggested by Arend V4: Also update brcmf_cfg80211_add_iface & print error for AP --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 8 ++++++-- drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c | 3 ++- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c index 3d09d23..e7975a3 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c @@ -669,14 +669,18 @@ static struct wireless_dev *brcmf_cfg80211_add_iface(struct wiphy *wiphy, return ERR_PTR(-EOPNOTSUPP); case NL80211_IFTYPE_AP: wdev = brcmf_ap_add_vif(wiphy, name, flags, params); - if (!IS_ERR(wdev)) + if (IS_ERR(wdev)) + brcmf_err("Failed to create AP interface %s: %d\n", name, PTR_ERR(wdev)); + else brcmf_cfg80211_update_proto_addr_mode(wdev); return wdev; case NL80211_IFTYPE_P2P_CLIENT: case NL80211_IFTYPE_P2P_GO: case NL80211_IFTYPE_P2P_DEVICE: wdev = brcmf_p2p_add_vif(wiphy, name, name_assign_type, type, flags, params); - if (!IS_ERR(wdev)) + if (IS_ERR(wdev)) + brcmf_err("Failed to create P2P interface %s: %d\n", name, PTR_ERR(wdev)); + else brcmf_cfg80211_update_proto_addr_mode(wdev); return wdev; case NL80211_IFTYPE_UNSPECIFIED: diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c index 1652a48..bc26aec 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c @@ -2031,7 +2031,7 @@ static int brcmf_p2p_request_p2p_if(struct brcmf_p2p_info *p2p, err = brcmf_fil_iovar_data_set(ifp, "p2p_ifadd", &if_request, sizeof(if_request)); if (err) - return err; + brcmf_err("p2p_ifadd failed %d\n", err); return err; } @@ -2185,6 +2185,7 @@ struct wireless_dev *brcmf_p2p_add_vif(struct wiphy *wiphy, const char *name, err = brcmf_p2p_request_p2p_if(&cfg->p2p, ifp, cfg->p2p.int_addr, iftype); if (err) { + brcmf_err("Failed to request P2P virtual interface %s\n", name); brcmf_cfg80211_arm_vif_event(cfg, NULL); goto fail; } -- 1.8.4.5 ^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-05-26 23:03 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-05-24 21:01 [PATCH] brcmfmac: print error in p2p_ifadd firmware command fails Rafał Miłecki 2016-05-24 21:05 ` [PATCH V2] brcmfmac: print error if " Rafał Miłecki 2016-05-25 21:05 ` Arend van Spriel 2016-05-25 22:44 ` [PATCH V3] " Rafał Miłecki 2016-05-26 8:07 ` Arend Van Spriel 2016-05-26 23:03 ` [PATCH V4] brcmfmac: print errors if creating interface fails Rafał Miłecki
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).