From: Christoph Fritz <chf.fritz@googlemail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Steve Glendinning <steve.glendinning@shawell.net>,
netdev@vger.kernel.org, Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: usbnet: smsc95xx: fix link detection for disabled autonegotiation
Date: Thu, 26 May 2016 13:01:31 +0200 [thread overview]
Message-ID: <1464260491.2726.11.camel@googlemail.com> (raw)
In-Reply-To: <20160526023120.GG21924@lunn.ch>
On Thu, 2016-05-26 at 04:31 +0200, Andrew Lunn wrote:
> On Thu, May 26, 2016 at 04:06:47AM +0200, Christoph Fritz wrote:
> > To detect link status up/down for connections where autonegotiation is
> > explicitly disabled, we don't get an irq but need to poll the status
> > register for link up/down detection.
> > This patch adds a workqueue to poll for link status.
>
> Did you consider using the phylib? It probably does the needed polling
> already, and it looks like the functions needed to implement an MDIO
> bus are already in place.
smsc95xx supports a relative wide range of PHYs which I don't have
access to in regard of testing. So I prefer the least invasive one (with
this patch) as mostly all of the other usbnet drivers do.
A merge to phylib while paying attention to all the suspend modes and
testing the wide range of PHYs would surely be the right thing to do.
Any thoughts on that?
Thanks
-- Christoph
next prev parent reply other threads:[~2016-05-26 11:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-26 2:06 usbnet: smsc95xx: fix link detection for disabled autonegotiation Christoph Fritz
2016-05-26 2:31 ` Andrew Lunn
2016-05-26 11:01 ` Christoph Fritz [this message]
2016-05-26 18:21 ` Florian Fainelli
2016-05-30 5:30 ` David Miller
2016-05-30 20:07 ` Christoph Fritz
2016-05-31 21:22 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1464260491.2726.11.camel@googlemail.com \
--to=chf.fritz@googlemail.com \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=steve.glendinning@shawell.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).